2023-10-25 07:18:35

by Peng Fan (OSS)

[permalink] [raw]
Subject: [PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

From: Peng Fan <[email protected]>

Support i.MX93 Analog module which produces PLL and OSC for Clock
Controller Module

Signed-off-by: Peng Fan <[email protected]>
---
V3:
Rename back to fsl,imx93-anatop.yaml

V2:
Update subject and commit, rename file to fsl,imx93-analog.yaml

.../bindings/clock/fsl,imx93-anatop.yaml | 42 +++++++++++++++++++
1 file changed, 42 insertions(+)
create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml

diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
new file mode 100644
index 000000000000..5d696ccc8986
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX93 Analog Clock Module
+
+maintainers:
+ - Peng Fan <[email protected]>
+
+description: |
+ NXP i.MX93 Analog module which produces PLL and OSC to Clock Controller
+ Module.
+
+properties:
+ compatible:
+ items:
+ - const: fsl,imx93-anatop
+
+ reg:
+ maxItems: 1
+
+ '#clock-cells':
+ const: 1
+
+required:
+ - compatible
+ - reg
+ - '#clock-cells'
+
+additionalProperties: false
+
+examples:
+ - |
+ clock-controller@44480000 {
+ compatible = "fsl,imx93-anatop";
+ reg = <0x44480000 0x2000>;
+ #clock-cells = <1>;
+ };
+
+...
--
2.37.1


2023-10-25 07:18:44

by Peng Fan (OSS)

[permalink] [raw]
Subject: [PATCH V3 2/2] arm64: dts: imx93: update analog node

From: Peng Fan <[email protected]>

The analog module produces PLL and OSC for Clock Controller Module. Since
the binding doc has been updated to clock-controller for this module,
Let's also update the device tree node.

Signed-off-by: Peng Fan <[email protected]>
---
V3:
None
V2:
Update subject/commit
Drop node alias

arch/arm64/boot/dts/freescale/imx93.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index ceccf4766440..235f1ae583e5 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -422,9 +422,10 @@ mediamix: power-domain@44462400 {
};
};

- anatop: anatop@44480000 {
- compatible = "fsl,imx93-anatop", "syscon";
+ clock-controller@44480000 {
+ compatible = "fsl,imx93-anatop";
reg = <0x44480000 0x2000>;
+ #clock-cells = <1>;
};

tmu: tmu@44482000 {
--
2.37.1

2023-10-25 14:31:19

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH V3 1/2] dt-bindings: clock: support i.MX93 Analog clock module

On Wed, Oct 25, 2023 at 03:22:41PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Support i.MX93 Analog module which produces PLL and OSC for Clock
> Controller Module
>
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Conor Dooley <[email protected]>

> ---
> V3:
> Rename back to fsl,imx93-anatop.yaml
>
> V2:
> Update subject and commit, rename file to fsl,imx93-analog.yaml
>
> .../bindings/clock/fsl,imx93-anatop.yaml | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> new file mode 100644
> index 000000000000..5d696ccc8986
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx93-anatop.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/fsl,imx93-anatop.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX93 Analog Clock Module
> +
> +maintainers:
> + - Peng Fan <[email protected]>
> +
> +description: |
> + NXP i.MX93 Analog module which produces PLL and OSC to Clock Controller
> + Module.

As I mentioned before, the module contains a PLL and an oscillator, it
doesn't produce them.

Cheers,
Conor.


Attachments:
(No filename) (1.47 kB)
signature.asc (235.00 B)
Download all attachments

2023-11-27 02:34:15

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH V3 2/2] arm64: dts: imx93: update analog node

On Wed, Oct 25, 2023 at 03:22:42PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The analog module produces PLL and OSC for Clock Controller Module. Since
> the binding doc has been updated to clock-controller for this module,
> Let's also update the device tree node.
>
> Signed-off-by: Peng Fan <[email protected]>

s/analog/anatop

Fixed it up and applied.

Shawn