2023-11-29 22:12:08

by Nico Pache

Subject: [PATCH] selftests/mm: dont run ksm_functional_tests twice

ksm functional test is already being run.
Remove the duplicate call to ./ksm_functional_tests.

Fixes: 93fb70aa5904 ("selftests/vm: add KSM unmerge tests")
Signed-off-by: Nico Pache <[email protected]>
Cc: David Hildenbrand <[email protected]>
---
tools/testing/selftests/mm/run_vmtests.sh | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index 00757445278e..c0212258b852 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -334,8 +334,6 @@ CATEGORY="ksm_numa" run_test ./ksm_tests -N -m 0

CATEGORY="ksm" run_test ./ksm_functional_tests

-run_test ./ksm_functional_tests
-
# protection_keys tests
if [ -x ./protection_keys_32 ]
then
--
2.41.0

2023-11-29 23:45:16

by Joel Savitz

Subject: Re: [PATCH] selftests/mm: dont run ksm_functional_tests twice

On Wed, Nov 29, 2023 at 5:11 PM Nico Pache <[email protected]> wrote:
>
> ksm functional test is already being run.
> Remove the duplicate call to ./ksm_functional_tests.
>
> Fixes: 93fb70aa5904 ("selftests/vm: add KSM unmerge tests")
> Signed-off-by: Nico Pache <[email protected]>
> Cc: David Hildenbrand <[email protected]>
> ---
> tools/testing/selftests/mm/run_vmtests.sh | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index 00757445278e..c0212258b852 100755
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -334,8 +334,6 @@ CATEGORY="ksm_numa" run_test ./ksm_tests -N -m 0
>
> CATEGORY="ksm" run_test ./ksm_functional_tests
>
> -run_test ./ksm_functional_tests
> -
> # protection_keys tests
> if [ -x ./protection_keys_32 ]
> then
> --
> 2.41.0
>

Acked-by: Joel Savitz <[email protected]>