Fix typos/grammar and spellos in documentation.
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Liam R. Howlett <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
---
lib/maple_tree.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff -- a/lib/maple_tree.c b/lib/maple_tree.c
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -16,8 +16,8 @@
* and are simply the slot index + the minimum of the node.
*
* In regular B-Tree terms, pivots are called keys. The term pivot is used to
- * indicate that the tree is specifying ranges, Pivots may appear in the
- * subtree with an entry attached to the value where as keys are unique to a
+ * indicate that the tree is specifying ranges. Pivots may appear in the
+ * subtree with an entry attached to the value whereas keys are unique to a
* specific position of a B-tree. Pivot values are inclusive of the slot with
* the same index.
*
@@ -2500,7 +2500,7 @@ static inline void mast_set_split_parent
}
/*
- * mas_topiary_node() - Dispose of a singe node
+ * mas_topiary_node() - Dispose of a single node
* @mas: The maple state for pushing nodes
* @enode: The encoded maple node
* @in_rcu: If the tree is in rcu mode
@@ -5474,7 +5474,7 @@ int mas_preallocate(struct ma_state *mas
goto ask_now;
}
- /* New root needs a singe node */
+ /* New root needs a single node */
if (unlikely(mte_is_root(mas->node)))
goto ask_now;
On Sat, Dec 09, 2023 at 10:38:39PM -0800, Randy Dunlap wrote:
> - * mas_topiary_node() - Dispose of a singe node
> + * mas_topiary_node() - Dispose of a single node
That's all well and good, but how do we dispose of singed nodes now?
Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>
On 12/10/23 13:13, Matthew Wilcox wrote:
> On Sat, Dec 09, 2023 at 10:38:39PM -0800, Randy Dunlap wrote:
>> - * mas_topiary_node() - Dispose of a singe node
>> + * mas_topiary_node() - Dispose of a single node
>
> That's all well and good, but how do we dispose of singed nodes now?
>
Yes, that leaves a problem here, but I'm sure that Liam can come up
with something.
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
On Sun, 10 Dec 2023 21:13:15 +0000 Matthew Wilcox <[email protected]> wrote:
> On Sat, Dec 09, 2023 at 10:38:39PM -0800, Randy Dunlap wrote:
> > - * mas_topiary_node() - Dispose of a singe node
> > + * mas_topiary_node() - Dispose of a single node
>
> That's all well and good, but how do we dispose of singed nodes now?
Lol, this is my all-time favorite typo!
hp2:/usr/src/mm> git log | grep Singed-off-by | wc -l
59
(sounds painful)
hp2:/usr/src/linux-6.7-rc4> grep -ri singe .
On 12/10/23 14:56, Andrew Morton wrote:
> On Sun, 10 Dec 2023 21:13:15 +0000 Matthew Wilcox <[email protected]> wrote:
>
>> On Sat, Dec 09, 2023 at 10:38:39PM -0800, Randy Dunlap wrote:
>>> - * mas_topiary_node() - Dispose of a singe node
>>> + * mas_topiary_node() - Dispose of a single node
>>
>> That's all well and good, but how do we dispose of singed nodes now?
>
> Lol, this is my all-time favorite typo!
>
>
> hp2:/usr/src/mm> git log | grep Singed-off-by | wc -l
> 59
>
> (sounds painful)
>
> hp2:/usr/src/linux-6.7-rc4> grep -ri singe .
>
Current linux-next shows:
$ git grep -iw singe
arch/x86/events/intel/pt.c: * In case of singe-entry ToPA, always put the self-referencing END
arch/x86/kvm/vmx/vmx.c: * evmcs in singe VM shares same assist page.
drivers/input/misc/yealink.c: /* Combine up to <len> consecutive LCD bytes in a singe request
drivers/net/ethernet/brocade/bna/bfa_defs_status.h: * NOTE: The error msgs are auto generated from the comments. Only singe line
kernel/trace/trace_events_filter.c: * struct prog_entry - a singe entry in the filter program
lib/maple_tree.c: * mas_topiary_node() - Dispose of a singe node
lib/maple_tree.c: /* New root needs a singe node */
sound/core/seq/seq_queue.c:/* enqueue a event to singe queue */
sound/pci/rme9652/hdspm.c: /* Changing between Singe, Double and Quad speed is not
but there is also "unsinged", "assinged", & "singel" if the -w is omitted.
And somehow the two Chinese translations of submitting-patches.rst contain
Singed-off-by.
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
* Randy Dunlap <[email protected]> [231210 18:54]:
>
>
> On 12/10/23 14:56, Andrew Morton wrote:
> > On Sun, 10 Dec 2023 21:13:15 +0000 Matthew Wilcox <[email protected]> wrote:
> >
> >> On Sat, Dec 09, 2023 at 10:38:39PM -0800, Randy Dunlap wrote:
> >>> - * mas_topiary_node() - Dispose of a singe node
> >>> + * mas_topiary_node() - Dispose of a single node
> >>
> >> That's all well and good, but how do we dispose of singed nodes now?
> >
> > Lol, this is my all-time favorite typo!
> >
> >
> > hp2:/usr/src/mm> git log | grep Singed-off-by | wc -l
> > 59
> >
> > (sounds painful)
> >
> > hp2:/usr/src/linux-6.7-rc4> grep -ri singe .
> >
>
> Current linux-next shows:
>
> $ git grep -iw singe
> arch/x86/events/intel/pt.c: * In case of singe-entry ToPA, always put the self-referencing END
> arch/x86/kvm/vmx/vmx.c: * evmcs in singe VM shares same assist page.
> drivers/input/misc/yealink.c: /* Combine up to <len> consecutive LCD bytes in a singe request
> drivers/net/ethernet/brocade/bna/bfa_defs_status.h: * NOTE: The error msgs are auto generated from the comments. Only singe line
> kernel/trace/trace_events_filter.c: * struct prog_entry - a singe entry in the filter program
> lib/maple_tree.c: * mas_topiary_node() - Dispose of a singe node
> lib/maple_tree.c: /* New root needs a singe node */
> sound/core/seq/seq_queue.c:/* enqueue a event to singe queue */
> sound/pci/rme9652/hdspm.c: /* Changing between Singe, Double and Quad speed is not
>
> but there is also "unsinged", "assinged", & "singel" if the -w is omitted.
>
> And somehow the two Chinese translations of submitting-patches.rst contain
> Singed-off-by.
>
Nodes become singed, especially around the edges, when writes are too
fast. We have to replace them with fresh nodes, otherwise tasks can't
find the VMAs in that area.
I will have to research how these other people were able to implement
'unsinged' - maybe there's a way to reuse these singed areas more
effectively.