2023-12-16 03:05:28

by Yajun Deng

Subject: [PATCH] mm: page_alloc: Simplify __free_pages_ok()

There is redundant code in __free_pages_ok(). Use free_one_page()
simplify it.

Signed-off-by: Yajun Deng <[email protected]>
---
mm/page_alloc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2f646773a934..f46af8616cac 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1262,7 +1262,6 @@ static void free_one_page(struct zone *zone,
static void __free_pages_ok(struct page *page, unsigned int order,
fpi_t fpi_flags)
{
- unsigned long flags;
int migratetype;
unsigned long pfn = page_to_pfn(page);
struct zone *zone = page_zone(page);
@@ -1277,13 +1276,7 @@ static void __free_pages_ok(struct page *page, unsigned int order,
*/
migratetype = get_pfnblock_migratetype(page, pfn);

- spin_lock_irqsave(&zone->lock, flags);
- if (unlikely(has_isolate_pageblock(zone) ||
- is_migrate_isolate(migratetype))) {
- migratetype = get_pfnblock_migratetype(page, pfn);
- }
- __free_one_page(page, pfn, zone, order, migratetype, fpi_flags);
- spin_unlock_irqrestore(&zone->lock, flags);
+ free_one_page(zone, page, pfn, order, migratetype, fpi_flags);

__count_vm_events(PGFREE, 1 << order);
}
--
2.25.1

2023-12-16 03:23:57

by Matthew Wilcox

Subject: Re: [PATCH] mm: page_alloc: Simplify __free_pages_ok()

On Sat, Dec 16, 2023 at 11:05:03AM +0800, Yajun Deng wrote:
> There is redundant code in __free_pages_ok(). Use free_one_page()
> simplify it.
>
> Signed-off-by: Yajun Deng <[email protected]>

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>