2023-12-25 05:41:25

by Shenghao Ding

Subject: [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for DSP mode

Move tas2563 from tas2562 header file to tas2781 header file, because
tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to
enable DSP mode for tas2563, it has been moved to tas2781 driver. As to
the hardware part, such as register setting and DSP firmware, all these
are stored in the binary firmware. What tas2781 drivder dooes is to parse
the firmware and download them to the tas2781 or tas2563, then power on
tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。
Only attention will be paid to downloading corresponding firmware.

Signed-off-by: Shenghao Ding <[email protected]>

---
Change in v3:
- Move tas2563 to tas2781 driver
- Add more comments on why move tas2563 to tas2781 driver
- Provide rationale in terms of bindings and hardware, not in terms of driver.
Or at least not only.
---
include/sound/tas2781.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
index a6c808b22318..45be543110ac 100644
--- a/include/sound/tas2781.h
+++ b/include/sound/tas2781.h
@@ -1,13 +1,13 @@
/* SPDX-License-Identifier: GPL-2.0 */
//
-// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier
+// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier
//
// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
// https://www.ti.com
//
-// The TAS2781 driver implements a flexible and configurable
+// The TAS2781/TAS2563 driver implements a flexible and configurable
// algo coefficient setting for one, two, or even multiple
-// TAS2781 chips.
+// TAS2781/TAS2563 chips.
//
// Author: Shenghao Ding <[email protected]>
// Author: Kevin Lu <[email protected]>
@@ -60,6 +60,7 @@

enum audio_device {
TAS2781 = 0,
+ TAS2563
};

enum device_catlog_id {
--
2.34.1

2023-12-27 17:41:41

by Andy Shevchenko

Subject: Re: [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for DSP mode

On Mon, Dec 25, 2023 at 01:39:29PM +0800, Shenghao Ding wrote:
> Move tas2563 from tas2562 header file to tas2781 header file, because
> tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to
> enable DSP mode for tas2563, it has been moved to tas2781 driver. As to
> the hardware part, such as register setting and DSP firmware, all these
> are stored in the binary firmware. What tas2781 drivder dooes is to parse
> the firmware and download them to the tas2781 or tas2563, then power on
> tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。
> Only attention will be paid to downloading corresponding firmware.

> enum audio_device {
> TAS2781 = 0,
> + TAS2563
> };

Please, make it ordered, it doesn't seem to be an ABI.

enum audio_device {
TAS2563,
TAS2781,
};

Yes, and leave comma as the last entry is _not_ a terminator.

--
With Best Regards,
Andy Shevchenko