Define enum inside the honeywell,transfer-function property block.
Set the correct irq edge in the example block.
Based on the datasheet, in table 13 on page 11:
"End-of-conversion indicator: This pin is set high when a measurement
and calculation have been completed and the data is ready to be
clocked out"
Add description on End-of-conversion interrupt.
Signed-off-by: Petre Rodan <[email protected]>
Signed-off-by: Andreas Klinger <[email protected]>
---
.../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
index d9e903fbfd99..84ced4e5a7da 100644
--- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
+++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
@@ -42,6 +42,10 @@ properties:
maxItems: 1
interrupts:
+ description:
+ Optional interrupt for indicating End-of-conversion.
+ If not present, the driver loops for a while until the received status
+ byte indicates correct measurement.
maxItems: 1
reset-gpios:
@@ -65,6 +69,7 @@ properties:
1 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
3 - C, 20% to 80% of 2^24 (3355443 .. 13421773)
+ enum: [1, 2, 3]
$ref: /schemas/types.yaml#/definitions/uint32
vdd-supply:
@@ -93,7 +98,7 @@ examples:
reg = <0x18>;
reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
interrupt-parent = <&gpio3>;
- interrupts = <21 IRQ_TYPE_EDGE_FALLING>;
+ interrupts = <21 IRQ_TYPE_EDGE_RISING>;
honeywell,pmin-pascal = <0>;
honeywell,pmax-pascal = <172369>;
honeywell,transfer-function = <1>;
--
2.41.0
On 24/12/2023 15:34, Petre Rodan wrote:
> Define enum inside the honeywell,transfer-function property block.
>
> Set the correct irq edge in the example block.
> Based on the datasheet, in table 13 on page 11:
> "End-of-conversion indicator: This pin is set high when a measurement
> and calculation have been completed and the data is ready to be
> clocked out"
>
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Sun, 24 Dec 2023 16:34:46 +0200
Petre Rodan <[email protected]> wrote:
> Define enum inside the honeywell,transfer-function property block.
>
> Set the correct irq edge in the example block.
> Based on the datasheet, in table 13 on page 11:
> "End-of-conversion indicator: This pin is set high when a measurement
> and calculation have been completed and the data is ready to be
> clocked out"
>
> Add description on End-of-conversion interrupt.
>
> Signed-off-by: Petre Rodan <[email protected]>
> Signed-off-by: Andreas Klinger <[email protected]>
What's the relationship between Andreas and this patch?
Petre seems to have sent it so either Andreas should have a Co-authored-by or
should be the author... Or not there at all
Thanks,
Jonathan
> ---
> .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> index d9e903fbfd99..84ced4e5a7da 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> @@ -42,6 +42,10 @@ properties:
> maxItems: 1
>
> interrupts:
> + description:
> + Optional interrupt for indicating End-of-conversion.
> + If not present, the driver loops for a while until the received status
> + byte indicates correct measurement.
> maxItems: 1
>
> reset-gpios:
> @@ -65,6 +69,7 @@ properties:
> 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773)
> + enum: [1, 2, 3]
> $ref: /schemas/types.yaml#/definitions/uint32
>
> vdd-supply:
> @@ -93,7 +98,7 @@ examples:
> reg = <0x18>;
> reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> interrupt-parent = <&gpio3>;
> - interrupts = <21 IRQ_TYPE_EDGE_FALLING>;
> + interrupts = <21 IRQ_TYPE_EDGE_RISING>;
> honeywell,pmin-pascal = <0>;
> honeywell,pmax-pascal = <172369>;
> honeywell,transfer-function = <1>;
> --
> 2.41.0
>
On Tue, 26 Dec 2023 16:28:39 +0000
Jonathan Cameron <[email protected]> wrote:
> On Sun, 24 Dec 2023 16:34:46 +0200
> Petre Rodan <[email protected]> wrote:
>
> > Define enum inside the honeywell,transfer-function property block.
> >
> > Set the correct irq edge in the example block.
> > Based on the datasheet, in table 13 on page 11:
> > "End-of-conversion indicator: This pin is set high when a measurement
> > and calculation have been completed and the data is ready to be
> > clocked out"
> >
> > Add description on End-of-conversion interrupt.
> >
> > Signed-off-by: Petre Rodan <[email protected]>
> > Signed-off-by: Andreas Klinger <[email protected]>
> What's the relationship between Andreas and this patch?
>
> Petre seems to have sent it so either Andreas should have a Co-authored-by or
Co-developed-by: that is.
> should be the author... Or not there at all
>
> Thanks,
>
> Jonathan
>
> > ---
> > .../bindings/iio/pressure/honeywell,mprls0025pa.yaml | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> > index d9e903fbfd99..84ced4e5a7da 100644
> > --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> > @@ -42,6 +42,10 @@ properties:
> > maxItems: 1
> >
> > interrupts:
> > + description:
> > + Optional interrupt for indicating End-of-conversion.
> > + If not present, the driver loops for a while until the received status
> > + byte indicates correct measurement.
> > maxItems: 1
> >
> > reset-gpios:
> > @@ -65,6 +69,7 @@ properties:
> > 1 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> > 2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> > 3 - C, 20% to 80% of 2^24 (3355443 .. 13421773)
> > + enum: [1, 2, 3]
> > $ref: /schemas/types.yaml#/definitions/uint32
> >
> > vdd-supply:
> > @@ -93,7 +98,7 @@ examples:
> > reg = <0x18>;
> > reset-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> > interrupt-parent = <&gpio3>;
> > - interrupts = <21 IRQ_TYPE_EDGE_FALLING>;
> > + interrupts = <21 IRQ_TYPE_EDGE_RISING>;
> > honeywell,pmin-pascal = <0>;
> > honeywell,pmax-pascal = <172369>;
> > honeywell,transfer-function = <1>;
> > --
> > 2.41.0
> >
>
>
Hello Cameron,
On Tue, Dec 26, 2023 at 04:28:39PM +0000, Jonathan Cameron wrote:
> On Sun, 24 Dec 2023 16:34:46 +0200
> Petre Rodan <[email protected]> wrote:
>
> > Define enum inside the honeywell,transfer-function property block.
> >
> > Set the correct irq edge in the example block.
> > Based on the datasheet, in table 13 on page 11:
> > "End-of-conversion indicator: This pin is set high when a measurement
> > and calculation have been completed and the data is ready to be
> > clocked out"
> >
> > Add description on End-of-conversion interrupt.
> >
> > Signed-off-by: Petre Rodan <[email protected]>
> > Signed-off-by: Andreas Klinger <[email protected]>
> What's the relationship between Andreas and this patch?
>
> Petre seems to have sent it so either Andreas should have a Co-authored-by or
> should be the author... Or not there at all
Andreas has written this driver as it is in the mainline tree right now and he
is marked as a maintainer for it.
A month back I told him about the enum off-by-one problem and also about my plan
of adding more features to the driver.
He was happy to accept my code and once I sent v1 of this patch to the list has
asked to work together for the v2 you see here. This has helped with cleaning up
the code. He requested the additional 'Signed-off-by' tag, but if you have a more
explicit one I will happily use it. 'Co-developed-by' it is.
He also owns an i2c version of the sensor so he was able to make sure that the
original half of the driver still works after my refactor, hence the 'Tested-by'
tag in the last patch.
please tell me how do the 'fixes'/feature/improvement tags/keywords look like?
are these to be added on the subject line, or should they reside near my
'Signed-off-by' inside the email body? I probably missed the documentation where
these are covered :)
also, should I add a 'Reviewed-by:' you for 09/10 and 10/10 (the last two patches)?
best regards,
peter
On Wed, 27 Dec 2023 09:11:35 +0200
Petre Rodan <[email protected]> wrote:
> Hello Cameron,
>
> On Tue, Dec 26, 2023 at 04:28:39PM +0000, Jonathan Cameron wrote:
> > On Sun, 24 Dec 2023 16:34:46 +0200
> > Petre Rodan <[email protected]> wrote:
> >
> > > Define enum inside the honeywell,transfer-function property block.
> > >
> > > Set the correct irq edge in the example block.
> > > Based on the datasheet, in table 13 on page 11:
> > > "End-of-conversion indicator: This pin is set high when a measurement
> > > and calculation have been completed and the data is ready to be
> > > clocked out"
> > >
> > > Add description on End-of-conversion interrupt.
> > >
> > > Signed-off-by: Petre Rodan <[email protected]>
> > > Signed-off-by: Andreas Klinger <[email protected]>
> > What's the relationship between Andreas and this patch?
> >
> > Petre seems to have sent it so either Andreas should have a Co-authored-by or
> > should be the author... Or not there at all
>
> Andreas has written this driver as it is in the mainline tree right now and he
> is marked as a maintainer for it.
> A month back I told him about the enum off-by-one problem and also about my plan
> of adding more features to the driver.
> He was happy to accept my code and once I sent v1 of this patch to the list has
> asked to work together for the v2 you see here. This has helped with cleaning up
> the code. He requested the additional 'Signed-off-by' tag, but if you have a more
> explicit one I will happily use it. 'Co-developed-by' it is.
Yup, needs combination of Co-developed-by and a Sign off for this case as in
effect both of you wrote the code.
>
> He also owns an i2c version of the sensor so he was able to make sure that the
> original half of the driver still works after my refactor, hence the 'Tested-by'
> tag in the last patch.
That's fine.
>
> please tell me how do the 'fixes'/feature/improvement tags/keywords look like?
> are these to be added on the subject line, or should they reside near my
> 'Signed-off-by' inside the email body? I probably missed the documentation where
> these are covered :)
See https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst
for lots of detail. The fixes tag has a particular format and goes in the main
tag block. Lots of examples in tree so can just take a look at the git history for
how to apply these rules in practice.
>
> also, should I add a 'Reviewed-by:' you for 09/10 and 10/10 (the last two patches)?
No. Tags should be explicitly given. I tend not to give RB for stuff I'll pick up
because they will have my SoB anyway as the person who applies the patches
and that includes reviewing.
In this case, Andreas asked for a tag to be included whereas I have not.
Jonathan
>
> best regards,
> peter