From: Li Hua Qian <[email protected]>
This patch adds a reserved memory for the TI AM65X platform watchdog to
reserve the specific info, triggering the watchdog reset in last boot,
to know if the board reboot is due to a watchdog reset.
Signed-off-by: Li Hua Qian <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index e26bd988e522..4bb20d493651 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
alignment = <0x1000>;
no-map;
};
+
+ /* To reserve the power-on(PON) reason for watchdog reset */
+ wdt_reset_memory_region: wdt-memory@a2200000 {
+ reg = <0x00 0xa2200000 0x00 0x1000>;
+ no-map;
+ };
};
leds {
@@ -718,3 +724,7 @@ &mcu_r5fss0_core1 {
<&mcu_r5fss0_core1_memory_region>;
mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
};
+
+&mcu_rti1 {
+ memory-region = <&wdt_reset_memory_region>;
+};
--
2.34.1
On 17:51-20230713, [email protected] wrote:
> From: Li Hua Qian <[email protected]>
I guess I should be explicit about this: Lets keep this dts patch as
"DONOTMERGE" in subject line for driver subsystem maintainer (I don't
want a repeat of cpufreq maintainers picking up dts and associated
warnings that are now pending fixes), resubmit at next rc1 and I can
queue up the dts once the maintainers pick up the driver and bindings.
Ref: https://lore.kernel.org/all/[email protected]/
>
> This patch adds a reserved memory for the TI AM65X platform watchdog to
> reserve the specific info, triggering the watchdog reset in last boot,
> to know if the board reboot is due to a watchdog reset.
>
> Signed-off-by: Li Hua Qian <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index e26bd988e522..4bb20d493651 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
> alignment = <0x1000>;
> no-map;
> };
> +
> + /* To reserve the power-on(PON) reason for watchdog reset */
> + wdt_reset_memory_region: wdt-memory@a2200000 {
> + reg = <0x00 0xa2200000 0x00 0x1000>;
> + no-map;
> + };
> };
>
> leds {
> @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 {
> <&mcu_r5fss0_core1_memory_region>;
> mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
> };
> +
> +&mcu_rti1 {
> + memory-region = <&wdt_reset_memory_region>;
> +};
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 7/14/23 15:52, Nishanth Menon wrote:
> On 17:51-20230713, [email protected] wrote:
>> From: Li Hua Qian <[email protected]>
>
> I guess I should be explicit about this: Lets keep this dts patch as
> "DONOTMERGE" in subject line for driver subsystem maintainer (I don't
> want a repeat of cpufreq maintainers picking up dts and associated
> warnings that are now pending fixes), resubmit at next rc1 and I can
> queue up the dts once the maintainers pick up the driver and bindings.
>
FWIW, I never pick up patches outside drivers/hwmon without explicit Ack
from responsible maintainers (and most definitely not dts patches unless
a maintainer responsible for the file(s) specifically asks me to do it
(which I think never happened).
Guenter
> Ref: https://lore.kernel.org/all/[email protected]/
>
>>
>> This patch adds a reserved memory for the TI AM65X platform watchdog to
>> reserve the specific info, triggering the watchdog reset in last boot,
>> to know if the board reboot is due to a watchdog reset.
>>
>> Signed-off-by: Li Hua Qian <[email protected]>
>> ---
>> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index e26bd988e522..4bb20d493651 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
>> alignment = <0x1000>;
>> no-map;
>> };
>> +
>> + /* To reserve the power-on(PON) reason for watchdog reset */
>> + wdt_reset_memory_region: wdt-memory@a2200000 {
>> + reg = <0x00 0xa2200000 0x00 0x1000>;
>> + no-map;
>> + };
>> };
>>
>> leds {
>> @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 {
>> <&mcu_r5fss0_core1_memory_region>;
>> mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
>> };
>> +
>> +&mcu_rti1 {
>> + memory-region = <&wdt_reset_memory_region>;
>> +};
>> --
>> 2.34.1
>>
>
On 16:27-20230714, Guenter Roeck wrote:
> On 7/14/23 15:52, Nishanth Menon wrote:
> > On 17:51-20230713, [email protected] wrote:
> > > From: Li Hua Qian <[email protected]>
> >
> > I guess I should be explicit about this: Lets keep this dts patch as
> > "DONOTMERGE" in subject line for driver subsystem maintainer (I don't
> > want a repeat of cpufreq maintainers picking up dts and associated
> > warnings that are now pending fixes), resubmit at next rc1 and I can
> > queue up the dts once the maintainers pick up the driver and bindings.
> >
>
> FWIW, I never pick up patches outside drivers/hwmon without explicit Ack
> from responsible maintainers (and most definitely not dts patches unless
> a maintainer responsible for the file(s) specifically asks me to do it
> (which I think never happened).
Oops Guenter, didn't mean to indicate your tree :( -> just wanted
to ensure that developers are clearly aware of what happens with
cross posting series involving multiple maintainers and level set
their expectations. Saves a bunch of private pings later on :)
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Hi Nishanth,
The maintainers have picked up the driver and bindings, as follows:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=29057cc5bddc785ea0a11534d7ad2546fa0872d3
Do you have time to work on the "DONOTMERGE" dts patch?
-----Original Message-----
From: Nishanth Menon <[email protected]>
Sent: Saturday, July 15, 2023 6:53 AM
To: Li, Hua Qian (DI FA CTR IPC CN PRC4) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Kiszka, Jan (T CED) <[email protected]>; Su, Bao Cheng (DI FA CTR IPC CN PRC4) <[email protected]>
Subject: Re: [PATCH v3 2/3] arm64: dts: ti: Add reserved memory for watchdog
On 17:51-20230713, [email protected] wrote:
> From: Li Hua Qian <[email protected]>
I guess I should be explicit about this: Lets keep this dts patch as "DONOTMERGE" in subject line for driver subsystem maintainer (I don't want a repeat of cpufreq maintainers picking up dts and associated warnings that are now pending fixes), resubmit at next rc1 and I can queue up the dts once the maintainers pick up the driver and bindings.
Ref: https://lore.kernel.org/all/[email protected]/
>
> This patch adds a reserved memory for the TI AM65X platform watchdog
> to reserve the specific info, triggering the watchdog reset in last
> boot, to know if the board reboot is due to a watchdog reset.
>
> Signed-off-by: Li Hua Qian <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index e26bd988e522..4bb20d493651 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
> alignment = <0x1000>;
> no-map;
> };
> +
> + /* To reserve the power-on(PON) reason for watchdog reset */
> + wdt_reset_memory_region: wdt-memory@a2200000 {
> + reg = <0x00 0xa2200000 0x00 0x1000>;
> + no-map;
> + };
> };
>
> leds {
> @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 {
> <&mcu_r5fss0_core1_memory_region>;
> mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>; };
> +
> +&mcu_rti1 {
> + memory-region = <&wdt_reset_memory_region>; };
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 08:16-20240108, Li, Hua Qian wrote:
> Hi Nishanth,
>
> The maintainers have picked up the driver and bindings, as follows:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=29057cc5bddc785ea0a11534d7ad2546fa0872d3
Not sure what you want us to look at here.
>
> Do you have time to work on the "DONOTMERGE" dts patch?
If the binding has hit master. please resubmit from the closest rc1 - at
this time, see if you can rebase on linux-next or wait till 6.8-rc1 is
tagged to rebase and re-submit.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D