From: Hui Liu <[email protected]>
Add definition for three LEDs to make sure they can
be enabled base on QCOM LPG LED driver.
Signed-off-by: Hui Liu <[email protected]>
---
Changes in v4:
- Removed "label" definition and added "function" definition.
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Rephrased commit text and updated the nodes to qcm6490-idp board file.
- Link to v2: https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Rephrased commit text and updated the nodes to board file.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 37c91fdf3ab9..8268fad505e7 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -5,6 +5,7 @@
/dts-v1/;
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sc7280.dtsi"
#include "pm7325.dtsi"
@@ -414,6 +415,28 @@ vreg_bob_3p296: bob {
};
};
+&pm8350c_pwm {
+ function = LED_FUNCTION_STATUS;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+};
+
&qupv3_id_0 {
status = "okay";
};
---
base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
change-id: 20231215-lpg-4aadd374811a
Best regards,
--
Hui Liu <[email protected]>
On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay
<[email protected]> wrote:
>
> From: Hui Liu <[email protected]>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <[email protected]>
> ---
> Changes in v4:
> - Removed "label" definition and added "function" definition.
You have removed "label", but you didn't add "function".
BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp"
> - Link to v3: https://lore.kernel.org/r/[email protected]
>
> Changes in v3:
> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
> - Link to v2: https://lore.kernel.org/all/[email protected]/
>
> Changes in v2:
> - Rephrased commit text and updated the nodes to board file.
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 37c91fdf3ab9..8268fad505e7 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -5,6 +5,7 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/leds/common.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> #include "sc7280.dtsi"
> #include "pm7325.dtsi"
> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob {
> };
> };
>
> +&pm8350c_pwm {
> + function = LED_FUNCTION_STATUS;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_RED>;
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_GREEN>;
> + };
> +
> + led@3 {
> + reg = <3>;
> + color = <LED_COLOR_ID_BLUE>;
> + };
> +};
> +
> &qupv3_id_0 {
> status = "okay";
> };
>
> ---
> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
> change-id: 20231215-lpg-4aadd374811a
>
> Best regards,
> --
> Hui Liu <[email protected]>
>
>
--
With best wishes
Dmitry
On 12/01/2024 04:05, Hui Liu via B4 Relay wrote:
> From: Hui Liu <[email protected]>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <[email protected]>
> ---
> Changes in v4:
> - Removed "label" definition and added "function" definition.
You did not test your patch before sending.
Subject is still wrong. Also, it still has unnecessary full stop. Drop it.
Best regards,
Krzysztof
On 1/12/2024 11:36 AM, Dmitry Baryshkov wrote:
> On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay
> <[email protected]> wrote:
>>
>> From: Hui Liu <[email protected]>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <[email protected]>
>> ---
>> Changes in v4:
>> - Removed "label" definition and added "function" definition.
>
> You have removed "label", but you didn't add "function".
I added function node "function = LED_FUNCTION_STATUS;"
Don't you mean this function node? I didn't get your mean.
>
> BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp"
OK, I will update it to qcm6490-idp.
>
>> - Link to v3: https://lore.kernel.org/r/[email protected]
>>
>> Changes in v3:
>> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
>> - Link to v2: https://lore.kernel.org/all/[email protected]/
>>
>> Changes in v2:
>> - Rephrased commit text and updated the nodes to board file.
>> - Link to v1: https://lore.kernel.org/r/[email protected]
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 37c91fdf3ab9..8268fad505e7 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -5,6 +5,7 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/leds/common.h>
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> #include "sc7280.dtsi"
>> #include "pm7325.dtsi"
>> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob {
>> };
>> };
>>
>> +&pm8350c_pwm {
>> + function = LED_FUNCTION_STATUS;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "okay";
>> +
>> + led@1 {
>> + reg = <1>;
>> + color = <LED_COLOR_ID_RED>;
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + };
>> +
>> + led@3 {
>> + reg = <3>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + };
>> +};
>> +
>> &qupv3_id_0 {
>> status = "okay";
>> };
>>
>> ---
>> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
>> change-id: 20231215-lpg-4aadd374811a
>>
>> Best regards,
>> --
>> Hui Liu <[email protected]>
>>
>>
>
>
On 1/12/2024 3:44 PM, Krzysztof Kozlowski wrote:
> On 12/01/2024 04:05, Hui Liu via B4 Relay wrote:
>> From: Hui Liu <[email protected]>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <[email protected]>
>> ---
>> Changes in v4:
>> - Removed "label" definition and added "function" definition.
>
> You did not test your patch before sending.
>
> Subject is still wrong. Also, it still has unnecessary full stop. Drop it.
I will update it to qcm6490-idp, I understood wrong previously.
>
> Best regards,
> Krzysztof
>
On Mon, 15 Jan 2024 at 07:53, hui liu <[email protected]> wrote:
> On 1/12/2024 11:36 AM, Dmitry Baryshkov wrote:
> > On Fri, 12 Jan 2024 at 05:07, Hui Liu via B4 Relay
> > <[email protected]> wrote:
> >>
> >> From: Hui Liu <[email protected]>
> >>
> >> Add definition for three LEDs to make sure they can
> >> be enabled base on QCOM LPG LED driver.
> >>
> >> Signed-off-by: Hui Liu <[email protected]>
> >> ---
> >> Changes in v4:
> >> - Removed "label" definition and added "function" definition.
> >
> > You have removed "label", but you didn't add "function".
> I added function node "function = LED_FUNCTION_STATUS;"
> Don't you mean this function node? I didn't get your mean.
The "function" is a property of the LED (each of them) rather than
being a top-level property.
> >
> > BTW: the commit subject is still wrong. Compare "qmp6490-idp" vs "qcs6490-idp"
> OK, I will update it to qcm6490-idp.
> >
> >> - Link to v3: https://lore.kernel.org/r/[email protected]
> >>
> >> Changes in v3:
> >> - Rephrased commit text and updated the nodes to qcm6490-idp board file.
> >> - Link to v2: https://lore.kernel.org/all/[email protected]/
> >>
> >> Changes in v2:
> >> - Rephrased commit text and updated the nodes to board file.
> >> - Link to v1: https://lore.kernel.org/r/[email protected]
> >> ---
> >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++
> >> 1 file changed, 23 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> >> index 37c91fdf3ab9..8268fad505e7 100644
> >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> >> @@ -5,6 +5,7 @@
> >>
> >> /dts-v1/;
> >>
> >> +#include <dt-bindings/leds/common.h>
> >> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >> #include "sc7280.dtsi"
> >> #include "pm7325.dtsi"
> >> @@ -414,6 +415,28 @@ vreg_bob_3p296: bob {
> >> };
> >> };
> >>
> >> +&pm8350c_pwm {
> >> + function = LED_FUNCTION_STATUS;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + status = "okay";
> >> +
> >> + led@1 {
> >> + reg = <1>;
> >> + color = <LED_COLOR_ID_RED>;
> >> + };
> >> +
> >> + led@2 {
> >> + reg = <2>;
> >> + color = <LED_COLOR_ID_GREEN>;
> >> + };
> >> +
> >> + led@3 {
> >> + reg = <3>;
> >> + color = <LED_COLOR_ID_BLUE>;
> >> + };
> >> +};
> >> +
> >> &qupv3_id_0 {
> >> status = "okay";
> >> };
> >>
> >> ---
> >> base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
> >> change-id: 20231215-lpg-4aadd374811a
> >>
> >> Best regards,
> >> --
> >> Hui Liu <[email protected]>
> >>
> >>
> >
> >
--
With best wishes
Dmitry