2024-01-12 07:23:19

by Kunwu Chan

Subject: [PATCH] vfio/fsl-mc: Remove unnecessary free in vfio_set_trigger

'irq->name' is initialed by kasprintf, so there is no need
to free it before initializing.

Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
Signed-off-by: Kunwu Chan <[email protected]>
---
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
index d62fbfff20b8..31f0716e7ab3 100644
--- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
+++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
@@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev,
hwirq = vdev->mc_dev->irqs[index]->virq;
if (irq->trigger) {
free_irq(hwirq, irq);
- kfree(irq->name);
eventfd_ctx_put(irq->trigger);
irq->trigger = NULL;
}
--
2.39.2

2024-01-12 15:36:31

by Alex Williamson

Subject: Re: [PATCH] vfio/fsl-mc: Remove unnecessary free in vfio_set_trigger

On Fri, 12 Jan 2024 15:21:28 +0800
Kunwu Chan <[email protected]> wrote:

> 'irq->name' is initialed by kasprintf, so there is no need
> to free it before initializing.

This is just as bogus as the vfio-platform version. Thanks,

Alex

> Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
> Signed-off-by: Kunwu Chan <[email protected]>
> ---
> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> index d62fbfff20b8..31f0716e7ab3 100644
> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c
> @@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev,
> hwirq = vdev->mc_dev->irqs[index]->virq;
> if (irq->trigger) {
> free_irq(hwirq, irq);
> - kfree(irq->name);
> eventfd_ctx_put(irq->trigger);
> irq->trigger = NULL;
> }