2024-01-16 19:58:13

by Sasha Levin

Subject: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac failed when running

From: duanqiangwen <[email protected]>

[ Upstream commit 87e839c82cc36346a2cd183ca941316902110716 ]

in some bonding mode, service need to change mac when
netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
priv_flag to support it.

Signed-off-by: duanqiangwen <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 1 +
drivers/net/ethernet/wangxun/txgbe/txgbe_main.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
index 8db804543e66..a5c623fd023e 100644
--- a/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
+++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_main.c
@@ -582,6 +582,7 @@ static int ngbe_probe(struct pci_dev *pdev,

netdev->priv_flags |= IFF_UNICAST_FLT;
netdev->priv_flags |= IFF_SUPP_NOFCS;
+ netdev->priv_flags |= IFF_LIVE_ADDR_CHANGE;

netdev->min_mtu = ETH_MIN_MTU;
netdev->max_mtu = WX_MAX_JUMBO_FRAME_SIZE -
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
index 526250102db2..a78da2309db5 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c
@@ -638,6 +638,7 @@ static int txgbe_probe(struct pci_dev *pdev,

netdev->priv_flags |= IFF_UNICAST_FLT;
netdev->priv_flags |= IFF_SUPP_NOFCS;
+ netdev->priv_flags |= IFF_LIVE_ADDR_CHANGE;

netdev->min_mtu = ETH_MIN_MTU;
netdev->max_mtu = WX_MAX_JUMBO_FRAME_SIZE -
--
2.43.0

2024-01-17 01:40:11

by Jakub Kicinski

Subject: Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac failed when running

On Tue, 16 Jan 2024 14:39:16 -0500 Sasha Levin wrote:
> in some bonding mode, service need to change mac when
> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
> priv_flag to support it.

Not really a fix, more of a feature ennoblement.
Let's drop it, we don't know what it may uncover.

We should probably start complaining when people use
the word "fix" for non-fixes :(

2024-01-30 22:51:30

by Sasha Levin

Subject: Re: [PATCH AUTOSEL 6.7 050/108] net: wangxun: fix changing mac failed when running

On Tue, Jan 16, 2024 at 05:39:55PM -0800, Jakub Kicinski wrote:
>On Tue, 16 Jan 2024 14:39:16 -0500 Sasha Levin wrote:
>> in some bonding mode, service need to change mac when
>> netif is running. Wangxun netdev add IFF_LIVE_ADDR_CHANGE
>> priv_flag to support it.
>
>Not really a fix, more of a feature ennoblement.
>Let's drop it, we don't know what it may uncover.
>
>We should probably start complaining when people use
>the word "fix" for non-fixes :(

I'll drop it :)

--
Thanks,
Sasha