2023-12-22 03:02:31

by Samuel Dionne-Riel

Subject: [PATCH v2] drm: panel-orientation-quirks: Add quirk for GPD Win Mini

Signed-off-by: Samuel Dionne-Riel <[email protected]>
---

Changes since v1:

- Add 1080p right-side up panel data
- Use the correct panel orientation

drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3d92f66e550c3..aa93129c3397e 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -117,6 +117,12 @@ static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftside_up = {
.orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
};

+static const struct drm_dmi_panel_orientation_data lcd1080x1920_rightside_up = {
+ .width = 1080,
+ .height = 1920,
+ .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
+};
+
static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
.width = 1200,
.height = 1920,
@@ -279,6 +285,12 @@ static const struct dmi_system_id orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1618-03")
},
.driver_data = (void *)&lcd720x1280_rightside_up,
+ }, { /* GPD Win Mini */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
+ },
+ .driver_data = (void *)&lcd1080x1920_rightside_up,
}, { /* I.T.Works TW891 */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
--
2.42.0

2024-01-18 19:27:57

by Samuel Dionne-Riel

Subject: Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for GPD Win Mini

On Thu, 21 Dec 2023 22:01:50 -0500
Samuel Dionne-Riel <[email protected]> wrote:

Hi,

Can I request a small share of your attention to review, and apply this patch?

Thank you all,

> Signed-off-by: Samuel Dionne-Riel <[email protected]>
> ---
>
> Changes since v1:
>
> - Add 1080p right-side up panel data
> - Use the correct panel orientation
>
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3d92f66e550c3..aa93129c3397e 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -117,6 +117,12 @@ static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftside_up = {
> .orientation = DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> };
>
> +static const struct drm_dmi_panel_orientation_data lcd1080x1920_rightside_up = {
> + .width = 1080,
> + .height = 1920,
> + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> +};
> +
> static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = {
> .width = 1200,
> .height = 1920,
> @@ -279,6 +285,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1618-03")
> },
> .driver_data = (void *)&lcd720x1280_rightside_up,
> + }, { /* GPD Win Mini */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1617-01")
> + },
> + .driver_data = (void *)&lcd1080x1920_rightside_up,
> }, { /* I.T.Works TW891 */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

2024-01-19 08:26:59

by Linus Walleij

Subject: Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for GPD Win Mini

On Fri, Dec 22, 2023 at 4:02 AM Samuel Dionne-Riel
<[email protected]> wrote:

> Signed-off-by: Samuel Dionne-Riel <[email protected]>

The patch looks OK, it was missing a commit message so I added
one and applied the patch to drm-misc-next.

Yours,
Linus Walleij