2024-01-22 14:08:03

by Changbin Du

[permalink] [raw]
Subject: Re: [PATCH v4 3/5] perf: script: add field 'disasm' to display mnemonic instructions

On Mon, Jan 22, 2024 at 05:41:42AM -0800, Andi Kleen wrote:
> > > >>
> > > > Updated as:
> > > >
> > > > When doing instruction trace decoding, insn, disasm and insnlen give the
> > > > instruction bytes, disassembled instructions and the instruction length
> > > > of the current instruction respectively.
> > >
> > > I wondered about mentioning that disasm needs perf to be compiled with
> > > disassembler support, but with a permissive license it seems likely
> > > that libcapstone support would generally be built into perf, so that
> > > should be fine.
> > >
> > Yes, libcapstone has a permissive license. It's available on most Linux distros.
>
> What I've seen in the past is that people who build perf from source
> often miss installing all the build the dependencies because perf continues
> without an error. Make sure that if that happens and someone uses the option
> there is a clear message that points to the build process.
>

Currently, perf build will show libcapstone available status at the beginning
of build and prompt user how to install it, as other dependencies do.

> -Andi

--
Cheers,
Changbin Du