2024-01-23 21:04:54

by Luca Weiss

Subject: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset

From: Vladimir Lypak <[email protected]>

Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.

Signed-off-by: Vladimir Lypak <[email protected]>
[luca: expand commit message, move entry]
Signed-off-by: Luca Weiss <[email protected]>
---
drivers/clk/qcom/gcc-msm8953.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-msm8953.c b/drivers/clk/qcom/gcc-msm8953.c
index 3e5a8cb14d4d..5725857faae6 100644
--- a/drivers/clk/qcom/gcc-msm8953.c
+++ b/drivers/clk/qcom/gcc-msm8953.c
@@ -4171,6 +4171,7 @@ static const struct qcom_reset_map gcc_msm8953_resets[] = {
[GCC_USB3PHY_PHY_BCR] = { 0x3f03c },
[GCC_USB3_PHY_BCR] = { 0x3f034 },
[GCC_USB_30_BCR] = { 0x3f070 },
+ [GCC_MDSS_BCR] = { 0x4d074 },
};

static const struct regmap_config gcc_msm8953_regmap_config = {

--
2.43.0

2024-01-24 12:17:16

by Konrad Dybcio

Subject: Re: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset

On 1/23/24 22:03, Luca Weiss wrote:
> From: Vladimir Lypak <[email protected]>
>
> Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.
>
> Signed-off-by: Vladimir Lypak <[email protected]>
> [luca: expand commit message, move entry]
> Signed-off-by: Luca Weiss <[email protected]>
> ---

I found some more definitions in lk2nd

88:#define GCC_CRYPTO_BCR (CLK_CTL_BASE + 0x16000)
106:#define SDCC1_BCR (CLK_CTL_BASE + 0x42000) /* block reset*/
125:#define SDCC2_BCR (CLK_CTL_BASE + 0x43000) /* block reset */
150:#define USB_HS_BCR (CLK_CTL_BASE + 0x41000)
155:#define GCC_QUSB2_PHY_BCR (CLK_CTL_BASE + 0x4103C)
168:#define USB_30_BCR (CLK_CTL_BASE + 0x3F070)
189:#define USB3_PHY_BCR (CLK_CTL_BASE + 0x3F034)
190:#define USB3PHY_PHY_BCR (CLK_CTL_BASE + 0x3F03C)

Couldn't find this one though, did you confirm that MDSS goes off
when you assert it?

Konrad

2024-01-25 21:27:04

by Luca Weiss

Subject: Re: [PATCH 2/3] clk: qcom: gcc-msm8953: add MDSS_BCR reset

On Mittwoch, 24. J?nner 2024 13:10:53 CET Konrad Dybcio wrote:
> On 1/23/24 22:03, Luca Weiss wrote:
> > From: Vladimir Lypak <[email protected]>
> >
> > Add an entry in the gcc driver for the MDSS_BCR reset found on MSM8953.
> >
> > Signed-off-by: Vladimir Lypak <[email protected]>
> > [luca: expand commit message, move entry]
> > Signed-off-by: Luca Weiss <[email protected]>
> > ---
>
> I found some more definitions in lk2nd
>
> 88:#define GCC_CRYPTO_BCR (CLK_CTL_BASE + 0x16000)
> 106:#define SDCC1_BCR (CLK_CTL_BASE + 0x42000) /*
> block reset*/ 125:#define SDCC2_BCR (CLK_CTL_BASE
> + 0x43000) /* block reset */ 150:#define USB_HS_BCR
> (CLK_CTL_BASE + 0x41000) 155:#define GCC_QUSB2_PHY_BCR
> (CLK_CTL_BASE + 0x4103C) 168:#define USB_30_BCR
> (CLK_CTL_BASE + 0x3F070)
> 189:#define USB3_PHY_BCR (CLK_CTL_BASE + 0x3F034)
> 190:#define USB3PHY_PHY_BCR (CLK_CTL_BASE + 0x3F03C)
>
> Couldn't find this one though, did you confirm that MDSS goes off
> when you assert it?

That one's defined here:
https://gerrit-public.fairphone.software/plugins/gitiles/kernel/msm-4.9/+/refs/heads/int/13/fp3/arch/arm64/boot/dts/qcom/msm8953-mdss-pll.dtsi#21

I'll add some of the others in v2.

>
> Konrad