As discussed before, here are suggestions to rename some regulators on
the KingFisher board. Patch 2 has an open question, this is why the
series is RFC. Looking forward to comments.
Based on the patch "arm64: dts: renesas: ulcb-kf: add regulators for
PCIe ch1".
Branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/upport_kf
Wolfram Sang (2):
arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics
arm64: dts: renesas: ulcb-kf: adapt sound 5v regulator to schematics
arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 28 ++++++++++++++----------
1 file changed, 16 insertions(+), 12 deletions(-)
--
2.39.2
Sound uses the standard 5V supply, so rename the fixed regulator as
such. Also add properties dcoumenting it is always on, also during boot.
Signed-off-by: Wolfram Sang <[email protected]>
---
Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
because 5V are not used on ULCB, but I am open to change it.
arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 6b6a0a8bc1db..84b0976503b7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -59,11 +59,13 @@ pcie_3v3: regulator-pcie-3v3 {
enable-active-high;
};
- snd_vcc5v: regulator-snd_vcc5v {
+ reg_5v: regulator-5v {
compatible = "regulator-fixed";
- regulator-name = "snd-vcc5v";
+ regulator-name = "fixed-5V";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
+ regulator-boot-on;
+ regulator-always-on;
};
wlan_en: regulator-wlan_en {
@@ -210,10 +212,10 @@ pcm3168a: audio-codec@44 {
VDD1-supply = <®_3p3v>;
VDD2-supply = <®_3p3v>;
- VCCAD1-supply = <&snd_vcc5v>;
- VCCAD2-supply = <&snd_vcc5v>;
- VCCDA1-supply = <&snd_vcc5v>;
- VCCDA2-supply = <&snd_vcc5v>;
+ VCCAD1-supply = <®_5v>;
+ VCCAD2-supply = <®_5v>;
+ VCCDA1-supply = <®_5v>;
+ VCCDA2-supply = <®_5v>;
};
gyroscope@6b {
--
2.39.2
Hi Wolfram,
Thanks for your patch!
On Mon, Jan 29, 2024 at 10:23 PM Wolfram Sang
<[email protected]> wrote:
> Sound uses the standard 5V supply, so rename the fixed regulator as
> such. Also add properties dcoumenting it is always on, also during boot.
documenting
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>
> Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
> because 5V are not used on ULCB, but I am open to change it.
I think it's fine to keep it here, as the regulator (U59) that generates
5V from 12V is present on the Kingfisher board. However, according
to the schematics, 5V is generated by the PMIC on the ULCB too, and
both 5V nets are connected through the board-to-board connectors?
Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v6.9.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds