From: Peng Fan <[email protected]>
Add i.MX95 flexcan which is compatible i.MX93 flexcan
Signed-off-by: Peng Fan <[email protected]>
---
Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
index 4162469c3c08..f197d9b516bb 100644
--- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
+++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
@@ -38,6 +38,9 @@ properties:
- fsl,imx6ul-flexcan
- fsl,imx6sx-flexcan
- const: fsl,imx6q-flexcan
+ - items:
+ - const: fsl,imx95-flexcan
+ - const: fsl,imx93-flexcan
- items:
- enum:
- fsl,ls1028ar1-flexcan
--
2.37.1
On Mon, Jan 22, 2024 at 05:17:38PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
>
> Signed-off-by: Peng Fan <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index 4162469c3c08..f197d9b516bb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -38,6 +38,9 @@ properties:
> - fsl,imx6ul-flexcan
> - fsl,imx6sx-flexcan
> - const: fsl,imx6q-flexcan
> + - items:
> + - const: fsl,imx95-flexcan
> + - const: fsl,imx93-flexcan
> - items:
> - enum:
> - fsl,ls1028ar1-flexcan
> --
> 2.37.1
>
On 22.01.2024 17:17:38, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
>
> Signed-off-by: Peng Fan <[email protected]>
Acked-by: Marc Kleine-Budde <[email protected]>
regards,
Marc
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index 4162469c3c08..f197d9b516bb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -38,6 +38,9 @@ properties:
> - fsl,imx6ul-flexcan
> - fsl,imx6sx-flexcan
> - const: fsl,imx6q-flexcan
> + - items:
> + - const: fsl,imx95-flexcan
> + - const: fsl,imx93-flexcan
> - items:
> - enum:
> - fsl,ls1028ar1-flexcan
> --
> 2.37.1
>
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> >
> > Signed-off-by: Peng Fan <[email protected]>
>
> Acked-by: Marc Kleine-Budde <[email protected]>
Hm, you don't apply CAN DTB patches?
> Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> string
>
> On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > >
> > > Signed-off-by: Peng Fan <[email protected]>
> >
> > Acked-by: Marc Kleine-Budde <[email protected]>
>
> Hm, you don't apply CAN DTB patches?
Nope. I am preparing dt-binding first, then post the i.MX95 SoC
dtsi. The CAN will be in the i.MX95 SOC dtsi file, not a
single patch only for CAN node.
Thanks,
Peng.
On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> > string
> >
> > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > >
> > > > Signed-off-by: Peng Fan <[email protected]>
> > >
> > > Acked-by: Marc Kleine-Budde <[email protected]>
> >
> > Hm, you don't apply CAN DTB patches?
>
> Nope. I am preparing dt-binding first, then post the i.MX95 SoC
> dtsi. The CAN will be in the i.MX95 SOC dtsi file, not a
> single patch only for CAN node.
The question was why isn't Marc, the CAN maintainer, applying this. I
have the same question.
Rob
> Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> string
>
> On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95
> > > compatible string
> > >
> > > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > > >
> > > > > Signed-off-by: Peng Fan <[email protected]>
> > > >
> > > > Acked-by: Marc Kleine-Budde <[email protected]>
> > >
> > > Hm, you don't apply CAN DTB patches?
> >
> > Nope. I am preparing dt-binding first, then post the i.MX95 SoC dtsi.
> > The CAN will be in the i.MX95 SOC dtsi file, not a single patch only
> > for CAN node.
>
> The question was why isn't Marc, the CAN maintainer, applying this. I have
> the same question.
That's fine, let's drop this patch, the CAN node will not be put in my soc dtsi
patch file, it will be in a separate patchset with some i.MX95 patches.
Thanks,
Peng.
>
> Rob
On Wed, Jan 31, 2024 at 11:22:49PM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> > string
> >
> > On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > > > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95
> > > > compatible string
> > > >
> > > > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > > > >
> > > > > > Signed-off-by: Peng Fan <[email protected]>
> > > > >
> > > > > Acked-by: Marc Kleine-Budde <[email protected]>
> > > >
> > > > Hm, you don't apply CAN DTB patches?
> > >
> > > Nope. I am preparing dt-binding first, then post the i.MX95 SoC dtsi.
> > > The CAN will be in the i.MX95 SOC dtsi file, not a single patch only
> > > for CAN node.
> >
> > The question was why isn't Marc, the CAN maintainer, applying this. I have
> > the same question.
>
> That's fine, let's drop this patch, the CAN node will not be put in my soc dtsi
> patch file, it will be in a separate patchset with some i.MX95 patches.
I am confused. This patch (for the binding) needs to be applied
regardless of what you are doing with your soc dtsi file.
On Mon, 22 Jan 2024 17:17:38 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
It seems this isn't getting applied to CAN tree, so I applied it.
Rob