2024-02-01 07:13:41

by Muhammad Usama Anjum

Subject: [PATCH] selftests/mm: on-fault-limit: run test without root privileges otherwise skip

The mmap() respects rlimit only for normal users. This test should be
run as normal user, without root privileges.

Fixes: b6221771d468 ("selftests/mm: run_vmtests: remove sudo and conform to tap")
Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
tools/testing/selftests/mm/on-fault-limit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/mm/on-fault-limit.c b/tools/testing/selftests/mm/on-fault-limit.c
index 0ea98ffab3589..431c1277d83a1 100644
--- a/tools/testing/selftests/mm/on-fault-limit.c
+++ b/tools/testing/selftests/mm/on-fault-limit.c
@@ -21,7 +21,7 @@ static void test_limit(void)
map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);

- ksft_test_result(map == MAP_FAILED, "Failed mmap\n");
+ ksft_test_result(map == MAP_FAILED, "The map failed respecting mlock limits\n");

if (map != MAP_FAILED)
munmap(map, 2 * lims.rlim_max);
@@ -33,8 +33,8 @@ int main(int argc, char **argv)
ksft_print_header();
ksft_set_plan(1);

- if (getuid())
- ksft_test_result_skip("Require root privileges to run\n");
+ if (!getuid())
+ ksft_test_result_skip("The test must be run from a normal user\n");
else
test_limit();

--
2.42.0

2024-02-01 12:34:13

by Muhammad Usama Anjum

Subject: Re: [PATCH] selftests/mm: on-fault-limit: run test without root privileges otherwise skip

Please disregard this patch. I'll send another patch to fix another thing.

On 2/1/24 12:13 PM, Muhammad Usama Anjum wrote:
> The mmap() respects rlimit only for normal users. This test should be
> run as normal user, without root privileges.
>
> Fixes: b6221771d468 ("selftests/mm: run_vmtests: remove sudo and conform to tap")
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> tools/testing/selftests/mm/on-fault-limit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/on-fault-limit.c b/tools/testing/selftests/mm/on-fault-limit.c
> index 0ea98ffab3589..431c1277d83a1 100644
> --- a/tools/testing/selftests/mm/on-fault-limit.c
> +++ b/tools/testing/selftests/mm/on-fault-limit.c
> @@ -21,7 +21,7 @@ static void test_limit(void)
> map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE,
> MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
>
> - ksft_test_result(map == MAP_FAILED, "Failed mmap\n");
> + ksft_test_result(map == MAP_FAILED, "The map failed respecting mlock limits\n");
>
> if (map != MAP_FAILED)
> munmap(map, 2 * lims.rlim_max);
> @@ -33,8 +33,8 @@ int main(int argc, char **argv)
> ksft_print_header();
> ksft_set_plan(1);
>
> - if (getuid())
> - ksft_test_result_skip("Require root privileges to run\n");
> + if (!getuid())
> + ksft_test_result_skip("The test must be run from a normal user\n");
> else
> test_limit();
>

--
BR,
Muhammad Usama Anjum