2024-02-01 12:12:34

by Andy Yan

Subject: [PATCH v2 3/4] arm64: dts: rockchip: rename vcc5v0_usb30_host regulator for Cool Pi CM5 EVB

According to the schematic, USB20 HOST0 and HOST1 each have their own
independent power supply, but these two regulators controlled by a
same GPIO, so give it a more appropriate name.

Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5 EVB")
Signed-off-by: Andy Yan <[email protected]>
---

Changes in v2:
- Add two lable for this regulator

arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
index 1b5681fe0471..9c0f408ef339 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
@@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator {
vin-supply = <&vcc3v3_sys>;
};

- vcc5v0_usb30_host: vcc5v0-usb30-host-regulator {
+ vcc5v0_usb_host1: vcc5v0_usb_host2: vcc5v0-usb-host-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc5v0_host";
regulator-boot-on;
@@ -200,12 +200,12 @@ &u2phy3 {
};

&u2phy2_host {
- phy-supply = <&vcc5v0_usb30_host>;
+ phy-supply = <&vcc5v0_usb_host1>;
status = "okay";
};

&u2phy3_host {
- phy-supply = <&vcc5v0_usb30_host>;
+ phy-supply = <&vcc5v0_usb_host2>;
status = "okay";
};

--
2.34.1

2024-02-01 12:36:13

by Dragan Simic

Subject: Re: [PATCH v2 3/4] arm64: dts: rockchip: rename vcc5v0_usb30_host regulator for Cool Pi CM5 EVB

On 2024-02-01 13:11, Andy Yan wrote:
> According to the schematic, USB20 HOST0 and HOST1 each have their own
> independent power supply, but these two regulators controlled by a
> same GPIO, so give it a more appropriate name.
>
> Fixes: 791c154c3982 ("arm64: dts: rockchip: Add support for rk3588
> based board Cool Pi CM5 EVB")
> Signed-off-by: Andy Yan <[email protected]>

Looking good to me.

Reviewed-by: Dragan Simic <[email protected]>

> ---
>
> Changes in v2:
> - Add two lable for this regulator
>
> arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
> b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
> index 1b5681fe0471..9c0f408ef339 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-coolpi-cm5-evb.dts
> @@ -84,7 +84,7 @@ vcc3v3_lcd: vcc3v3-lcd-regulator {
> vin-supply = <&vcc3v3_sys>;
> };
>
> - vcc5v0_usb30_host: vcc5v0-usb30-host-regulator {
> + vcc5v0_usb_host1: vcc5v0_usb_host2: vcc5v0-usb-host-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vcc5v0_host";
> regulator-boot-on;
> @@ -200,12 +200,12 @@ &u2phy3 {
> };
>
> &u2phy2_host {
> - phy-supply = <&vcc5v0_usb30_host>;
> + phy-supply = <&vcc5v0_usb_host1>;
> status = "okay";
> };
>
> &u2phy3_host {
> - phy-supply = <&vcc5v0_usb30_host>;
> + phy-supply = <&vcc5v0_usb_host2>;
> status = "okay";
> };