On Mon, Feb 12, 2024 at 10:53:07AM +0100, Bartosz Golaszewski wrote:
> On Sat, Feb 10, 2024 at 6:37 AM Kent Gibson <[email protected]> wrote:
> >
> > On Thu, Feb 08, 2024 at 10:59:19AM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <[email protected]>
> > >
> > > With all accesses to gdev->chip being protected with SRCU, we can now
> > > remove the RW-semaphore specific to the character device which
> > > fullfilled the same role up to this point.
> > >
> >
> > fulfilled
> >
> > > Signed-off-by: Bartosz Golaszewski <[email protected]>
> > > Reviewed-by: Linus Walleij <[email protected]>
> > > ---
> > > drivers/gpio/gpiolib-cdev.c | 1 -
> > > drivers/gpio/gpiolib.c | 4 ----
> > > drivers/gpio/gpiolib.h | 5 -----
> > > 3 files changed, 10 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> > > index ccdeed013f6b..9323b357df43 100644
> > > --- a/drivers/gpio/gpiolib-cdev.c
> > > +++ b/drivers/gpio/gpiolib-cdev.c
> > > @@ -24,7 +24,6 @@
> > > #include <linux/pinctrl/consumer.h>
> > > #include <linux/poll.h>
> > > #include <linux/rbtree.h>
> > > -#include <linux/rwsem.h>
> > > #include <linux/seq_file.h>
> > > #include <linux/spinlock.h>
> > > #include <linux/timekeeping.h>
> >
> > Shouldn't this be part of the rwsem -> srcu switch in the previous
> > patch?
> >
>
> That other patch was already huge. I figured this should be separate.
>
To be clear, I mean just this header removal, not the whole patch.
Cheers,
Kent.
On Mon, 12 Feb 2024 at 10:57, Kent Gibson <[email protected]> wrote:
>
> On Mon, Feb 12, 2024 at 10:53:07AM +0100, Bartosz Golaszewski wrote:
> > On Sat, Feb 10, 2024 at 6:37 AM Kent Gibson <[email protected]> wrote:
> > >
> > > On Thu, Feb 08, 2024 at 10:59:19AM +0100, Bartosz Golaszewski wrote:
> > > > From: Bartosz Golaszewski <[email protected]>
> > > >
> > > > With all accesses to gdev->chip being protected with SRCU, we can now
> > > > remove the RW-semaphore specific to the character device which
> > > > fullfilled the same role up to this point.
> > > >
> > >
> > > fulfilled
> > >
> > > > Signed-off-by: Bartosz Golaszewski <[email protected]>
> > > > Reviewed-by: Linus Walleij <[email protected]>
> > > > ---
> > > > drivers/gpio/gpiolib-cdev.c | 1 -
> > > > drivers/gpio/gpiolib.c | 4 ----
> > > > drivers/gpio/gpiolib.h | 5 -----
> > > > 3 files changed, 10 deletions(-)
> > > >
> > > > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> > > > index ccdeed013f6b..9323b357df43 100644
> > > > --- a/drivers/gpio/gpiolib-cdev.c
> > > > +++ b/drivers/gpio/gpiolib-cdev.c
> > > > @@ -24,7 +24,6 @@
> > > > #include <linux/pinctrl/consumer.h>
> > > > #include <linux/poll.h>
> > > > #include <linux/rbtree.h>
> > > > -#include <linux/rwsem.h>
> > > > #include <linux/seq_file.h>
> > > > #include <linux/spinlock.h>
> > > > #include <linux/timekeeping.h>
> > >
> > > Shouldn't this be part of the rwsem -> srcu switch in the previous
> > > patch?
> > >
> >
> > That other patch was already huge. I figured this should be separate.
> >
>
> To be clear, I mean just this header removal, not the whole patch.
>
> Cheers,
> Kent.
Ah, then it makes sense indeed. I'll fix it in tree.
Bart