2024-02-12 11:15:40

by Arnd Bergmann

Subject: [PATCH] leds: qcom-lpg: add QCOM_PBS dependency

From: Arnd Bergmann <[email protected]>

The lpg driver fails to link now when the pbs driver is in a loadable module:

x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'

Add a dependency to avoid the broken configuration. Apparently there is still
a use for lpg with pbs disabled entirely for certain chips, so allow both
but not LEDS_QCOM_LPG=y with QCOM_PBS=m.

Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/leds/rgb/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
index e66bd21b9852..eaeafdd5eaae 100644
--- a/drivers/leds/rgb/Kconfig
+++ b/drivers/leds/rgb/Kconfig
@@ -41,6 +41,7 @@ config LEDS_QCOM_LPG
tristate "LED support for Qualcomm LPG"
depends on OF
depends on PWM
+ depends on QCOM_PBS || !QCOM_PBS
depends on SPMI
help
This option enables support for the Light Pulse Generator found in a
--
2.39.2

2024-02-12 20:17:37

by Jean Delvare

Subject: Re: [PATCH] leds: qcom-lpg: add QCOM_PBS dependency

On Mon, 12 Feb 2024 12:15:02 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The lpg driver fails to link now when the pbs driver is in a loadable module:
>
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
> leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
> leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'
>
> Add a dependency to avoid the broken configuration. Apparently there is still
> a use for lpg with pbs disabled entirely for certain chips, so allow both
> but not LEDS_QCOM_LPG=y with QCOM_PBS=m.
>
> Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/leds/rgb/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index e66bd21b9852..eaeafdd5eaae 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -41,6 +41,7 @@ config LEDS_QCOM_LPG
> tristate "LED support for Qualcomm LPG"
> depends on OF
> depends on PWM
> + depends on QCOM_PBS || !QCOM_PBS
> depends on SPMI
> help
> This option enables support for the Light Pulse Generator found in a

Reviewed-by: Jean Delvare <[email protected]>

Thanks,
--
Jean Delvare
SUSE L3 Support

2024-02-23 14:53:50

by Lee Jones

Subject: Re: (subset) [PATCH] leds: qcom-lpg: add QCOM_PBS dependency

On Mon, 12 Feb 2024 12:15:02 +0100, Arnd Bergmann wrote:
> The lpg driver fails to link now when the pbs driver is in a loadable module:
>
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
> leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
> x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
> leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'
>
> [...]

Applied, thanks!

[1/1] leds: qcom-lpg: add QCOM_PBS dependency
commit: 2b6e12192159605ed7cffd36892cea2c82786975

--
Lee Jones [李琼斯]