According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
supply regulator must be defined via the 'vdd-supply' property.
The driver however requests for the 'vdda-phy' regulator which
results in the following message when the driver is probed on
a IPQ5018 based board with a device tree matching to the schema:
qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator
qcom-m31usb-phy 5b000.phy: Registered M31 USB phy
This means that the regulator specified in the device tree never
gets enabled.
Change the driver to use the 'vdd' name for the regulator as per
defined in the schema in order to ensure that the corresponding
regulator gets enabled.
Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
Signed-off-by: Gabor Juhos <[email protected]>
---
drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
index c2590579190a..9d84858ba1db 100644
--- a/drivers/phy/qualcomm/phy-qcom-m31.c
+++ b/drivers/phy/qualcomm/phy-qcom-m31.c
@@ -297,7 +297,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(qphy->phy),
"failed to create phy\n");
- qphy->vreg = devm_regulator_get(dev, "vdda-phy");
+ qphy->vreg = devm_regulator_get(dev, "vdd");
if (IS_ERR(qphy->vreg))
return dev_err_probe(dev, PTR_ERR(qphy->phy),
"failed to get vreg\n");
---
base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
change-id: 20240220-phy-qcom-m31-regulator-fix-97555a4650b1
Best regards,
--
Gabor Juhos <[email protected]>
On Tue, Feb 20, 2024 at 08:13:47PM +0100, Gabor Juhos wrote:
> According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
> supply regulator must be defined via the 'vdd-supply' property.
> The driver however requests for the 'vdda-phy' regulator which
> results in the following message when the driver is probed on
> a IPQ5018 based board with a device tree matching to the schema:
>
> qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator
> qcom-m31usb-phy 5b000.phy: Registered M31 USB phy
>
> This means that the regulator specified in the device tree never
> gets enabled.
>
> Change the driver to use the 'vdd' name for the regulator as per
> defined in the schema in order to ensure that the corresponding
> regulator gets enabled.
>
> Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
> Signed-off-by: Gabor Juhos <[email protected]>
> ---
> drivers/phy/qualcomm/phy-qcom-m31.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c
> index c2590579190a..9d84858ba1db 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31.c
> @@ -297,7 +297,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(qphy->phy),
> "failed to create phy\n");
>
> - qphy->vreg = devm_regulator_get(dev, "vdda-phy");
> + qphy->vreg = devm_regulator_get(dev, "vdd");
> if (IS_ERR(qphy->vreg))
> return dev_err_probe(dev, PTR_ERR(qphy->phy),
> "failed to get vreg\n");
>
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240220-phy-qcom-m31-regulator-fix-97555a4650b1
Reviewed-by: Varadarajan Narayanan <[email protected]>
2024. 02. 23. 12:49 keltezéssel, Varadarajan Narayanan írta:
> On Tue, Feb 20, 2024 at 08:13:47PM +0100, Gabor Juhos wrote:
>> According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
>> supply regulator must be defined via the 'vdd-supply' property.
>> The driver however requests for the 'vdda-phy' regulator which
>> results in the following message when the driver is probed on
>> a IPQ5018 based board with a device tree matching to the schema:
>>
<snip>
> Reviewed-by: Varadarajan Narayanan <[email protected]>
Thank you for the review!
Regards,
Gabor
On 20-02-24, 20:13, Gabor Juhos wrote:
> According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
> supply regulator must be defined via the 'vdd-supply' property.
> The driver however requests for the 'vdda-phy' regulator which
> results in the following message when the driver is probed on
> a IPQ5018 based board with a device tree matching to the schema:
>
> qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator
> qcom-m31usb-phy 5b000.phy: Registered M31 USB phy
>
> This means that the regulator specified in the device tree never
> gets enabled.
>
> Change the driver to use the 'vdd' name for the regulator as per
> defined in the schema in order to ensure that the corresponding
> regulator gets enabled.
This lgtm, but it doesnt apply on phy/fixes
Can you please rebase
--
~Vinod
On Tue, 20 Feb 2024 20:13:47 +0100, Gabor Juhos wrote:
> According to the 'qcom,ipq5332-usb-hsphy.yaml' schema, the 5V
> supply regulator must be defined via the 'vdd-supply' property.
> The driver however requests for the 'vdda-phy' regulator which
> results in the following message when the driver is probed on
> a IPQ5018 based board with a device tree matching to the schema:
>
> qcom-m31usb-phy 5b000.phy: supply vdda-phy not found, using dummy regulator
> qcom-m31usb-phy 5b000.phy: Registered M31 USB phy
>
> [...]
Applied, thanks!
[1/1] phy: qcom: m31: match requested regulator name with dt schema
commit: 47b3e2f3914ae5e8d9025d65ae5cffcbb54bc9c3
Best regards,
--
~Vinod