2024-02-23 12:48:15

by Alexander Stein

[permalink] [raw]
Subject: [PATCH 1/1] media: dt-bindings: sony,imx290: Allow props from video-interface-devices

Allow properties from video-interface-devices. This aligns the bindings
to sony,imx415.yaml. Changes inspired by commit e2e73ed46c395 ("media:
dt-bindings: sony,imx415: Allow props from video-interface-devices")

Signed-off-by: Alexander Stein <[email protected]>
---
Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
index a531badc16c98..e957b5dd4284d 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
@@ -23,6 +23,9 @@ description: |-
is treated the same as this as it was the original compatible string.
imx290llr is the mono version of the sensor.

+allOf:
+ - $ref: ../video-interface-devices.yaml#
+
properties:
compatible:
oneOf:
@@ -101,7 +104,7 @@ required:
- vdddo-supply
- port

-additionalProperties: false
+unevaluatedProperties: false

examples:
- |
--
2.34.1



2024-02-23 13:17:11

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 1/1] media: dt-bindings: sony,imx290: Allow props from video-interface-devices

Hi Alexander,

Thank you for the patch.

On Fri, Feb 23, 2024 at 01:47:43PM +0100, Alexander Stein wrote:
> Allow properties from video-interface-devices. This aligns the bindings
> to sony,imx415.yaml. Changes inspired by commit e2e73ed46c395 ("media:
> dt-bindings: sony,imx415: Allow props from video-interface-devices")
>
> Signed-off-by: Alexander Stein <[email protected]>
> ---
> Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> index a531badc16c98..e957b5dd4284d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> @@ -23,6 +23,9 @@ description: |-
> is treated the same as this as it was the original compatible string.
> imx290llr is the mono version of the sensor.
>
> +allOf:
> + - $ref: ../video-interface-devices.yaml#

I think this should be

- $ref: /schemas/media/video-interface-devices.yaml#

Reviewed-by: Laurent Pinchart <[email protected]>

Bonus points if you would like to send patches to the DT bindings of the
gc0308, gc2145, imx214 and imx415 to fix that :-)

> +
> properties:
> compatible:
> oneOf:
> @@ -101,7 +104,7 @@ required:
> - vdddo-supply
> - port
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |

--
Regards,

Laurent Pinchart

2024-02-23 18:35:35

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/1] media: dt-bindings: sony,imx290: Allow props from video-interface-devices

On Fri, Feb 23, 2024 at 01:47:43PM +0100, Alexander Stein wrote:
> Allow properties from video-interface-devices. This aligns the bindings
> to sony,imx415.yaml. Changes inspired by commit e2e73ed46c395 ("media:
> dt-bindings: sony,imx415: Allow props from video-interface-devices")
>
> Signed-off-by: Alexander Stein <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.


Attachments:
(No filename) (433.00 B)
signature.asc (235.00 B)
Download all attachments