2024-02-23 13:01:56

by Javier Carrasco

[permalink] [raw]
Subject: [PATCH] dt-bindings: iio: light: vishay,veml6075: make vdd-supply required

The VEML6075 requires a single supply to operate. The property already
exists in the bindings and it is used in the example, but it is still
not on the list of required properties.

Signed-off-by: Javier Carrasco <[email protected]>
---
The driver and bindings for the VEML6075 UV sensor were merged in the
merge window for v6.8 i.e. they have not been released yet beyond rc.

Applying this patch as a fix now would avoid an ABI break like the
recently discussed here:

https://lore.kernel.org/linux-iio/[email protected]/

On the other hand, from the same discussion it can be concluded that the
major risk would be a potential warning with dtbs_check, in case this
patch is applied during the next merge window.

The VEML6075 driver already handles the power supply with
devm_regulator_get_enable().
---
Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
index abee04cd126e..91c318746bf3 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
@@ -21,6 +21,7 @@ properties:
required:
- compatible
- reg
+ - vdd-supply

additionalProperties: false


---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240223-veml6075_vdd-e2220158ffda

Best regards,
--
Javier Carrasco <[email protected]>



2024-02-23 18:35:12

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: light: vishay,veml6075: make vdd-supply required

On Fri, Feb 23, 2024 at 02:01:33PM +0100, Javier Carrasco wrote:
> The VEML6075 requires a single supply to operate. The property already
> exists in the bindings and it is used in the example, but it is still
> not on the list of required properties.
>
> Signed-off-by: Javier Carrasco <[email protected]>
> ---
> The driver and bindings for the VEML6075 UV sensor were merged in the
> merge window for v6.8 i.e. they have not been released yet beyond rc.
>
> Applying this patch as a fix now would avoid an ABI break like the
> recently discussed here:
>
> https://lore.kernel.org/linux-iio/[email protected]/
>
> On the other hand, from the same discussion it can be concluded that the
> major risk would be a potential warning with dtbs_check, in case this
> patch is applied during the next merge window.

I don't care if it introduces a dtbs_check problem, we can fix those.
The device clearly needs power and at least for linux it being missing
gets handled perfectly fine. I think it's pretty reasonable to do this.

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

>
> The VEML6075 driver already handles the power supply with
> devm_regulator_get_enable().
> ---
> Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> index abee04cd126e..91c318746bf3 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> @@ -21,6 +21,7 @@ properties:
> required:
> - compatible
> - reg
> + - vdd-supply
>
> additionalProperties: false
>
>
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240223-veml6075_vdd-e2220158ffda
>
> Best regards,
> --
> Javier Carrasco <[email protected]>
>


Attachments:
(No filename) (2.03 kB)
signature.asc (235.00 B)
Download all attachments

2024-02-24 19:19:05

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: light: vishay,veml6075: make vdd-supply required

On Fri, 23 Feb 2024 18:34:39 +0000
Conor Dooley <[email protected]> wrote:

> On Fri, Feb 23, 2024 at 02:01:33PM +0100, Javier Carrasco wrote:
> > The VEML6075 requires a single supply to operate. The property already
> > exists in the bindings and it is used in the example, but it is still
> > not on the list of required properties.
> >
> > Signed-off-by: Javier Carrasco <[email protected]>
> > ---
> > The driver and bindings for the VEML6075 UV sensor were merged in the
> > merge window for v6.8 i.e. they have not been released yet beyond rc.
> >
> > Applying this patch as a fix now would avoid an ABI break like the
> > recently discussed here:
> >
> > https://lore.kernel.org/linux-iio/[email protected]/
> >
> > On the other hand, from the same discussion it can be concluded that the
> > major risk would be a potential warning with dtbs_check, in case this
> > patch is applied during the next merge window.
>
> I don't care if it introduces a dtbs_check problem, we can fix those.
> The device clearly needs power and at least for linux it being missing
> gets handled perfectly fine. I think it's pretty reasonable to do this.
>
> Acked-by: Conor Dooley <[email protected]>
>
Applied to the togreg branch of iio.git and pushed out as testing.

Jonathan

> Cheers,
> Conor.
>
> >
> > The VEML6075 driver already handles the power supply with
> > devm_regulator_get_enable().
> > ---
> > Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> > index abee04cd126e..91c318746bf3 100644
> > --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> > +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6075.yaml
> > @@ -21,6 +21,7 @@ properties:
> > required:
> > - compatible
> > - reg
> > + - vdd-supply
> >
> > additionalProperties: false
> >
> >
> > ---
> > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> > change-id: 20240223-veml6075_vdd-e2220158ffda
> >
> > Best regards,
> > --
> > Javier Carrasco <[email protected]>
> >