2024-02-23 02:50:04

by Liu Ying

Subject: [PATCH] arm64: dts: imx8mp-evk: Fix hdmi@3d node

The hdmi@3d node's compatible string is "adi,adv7535" instead of
"adi,adv7533" or "adi,adv751*".

Fix the hdmi@3d node by means of:
* Use default register addresses for "cec", "edid" and "packet", because
there is no need to use a non-default address map.
* Add missing interrupt related properties.
* Drop "adi,input-*" properties which are only valid for adv751*.
* Add VEXT_3V3 fixed regulator.
* Add "*-supply" properties, since most are required.
* Fix label names - s/adv7533/adv7535/.

Fixes: 65344b9bed3a ("arm64: dts: imx8mp-evk: Add HDMI support")
Signed-off-by: Liu Ying <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 33 +++++++++++++-------
1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index f87fa5a948cc..9beba8d6a0df 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -23,7 +23,7 @@ hdmi-connector {

port {
hdmi_connector_in: endpoint {
- remote-endpoint = <&adv7533_out>;
+ remote-endpoint = <&adv7535_out>;
};
};
};
@@ -107,6 +107,13 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
enable-active-high;
};

+ reg_vext_3v3: regulator-vext-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "VEXT_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
sound {
compatible = "simple-audio-card";
simple-audio-card,name = "wm8960-audio";
@@ -364,7 +371,7 @@ BUCK4 {
regulator-always-on;
};

- BUCK5 {
+ reg_buck5: BUCK5 {
regulator-name = "BUCK5";
regulator-min-microvolt = <1650000>;
regulator-max-microvolt = <1950000>;
@@ -415,14 +422,16 @@ &i2c2 {

hdmi@3d {
compatible = "adi,adv7535";
- reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
- reg-names = "main", "cec", "edid", "packet";
+ reg = <0x3d>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
adi,dsi-lanes = <4>;
- adi,input-depth = <8>;
- adi,input-colorspace = "rgb";
- adi,input-clock = "1x";
- adi,input-style = <1>;
- adi,input-justification = "evenly";
+ avdd-supply = <&reg_buck5>;
+ dvdd-supply = <&reg_buck5>;
+ pvdd-supply = <&reg_buck5>;
+ a2vdd-supply = <&reg_buck5>;
+ v3p3-supply = <&reg_vext_3v3>;
+ v1p2-supply = <&reg_buck5>;

ports {
#address-cells = <1>;
@@ -431,7 +440,7 @@ ports {
port@0 {
reg = <0>;

- adv7533_in: endpoint {
+ adv7535_in: endpoint {
remote-endpoint = <&dsi_out>;
};
};
@@ -439,7 +448,7 @@ adv7533_in: endpoint {
port@1 {
reg = <1>;

- adv7533_out: endpoint {
+ adv7535_out: endpoint {
remote-endpoint = <&hdmi_connector_in>;
};
};
@@ -524,7 +533,7 @@ port@1 {
reg = <1>;

dsi_out: endpoint {
- remote-endpoint = <&adv7533_in>;
+ remote-endpoint = <&adv7535_in>;
data-lanes = <1 2 3 4>;
};
};
--
2.37.1

2024-02-25 13:29:19

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mp-evk: Fix hdmi@3d node

On Fri, Feb 23, 2024 at 10:57:38AM +0800, Liu Ying wrote:
> The hdmi@3d node's compatible string is "adi,adv7535" instead of
> "adi,adv7533" or "adi,adv751*".
>
> Fix the hdmi@3d node by means of:
> * Use default register addresses for "cec", "edid" and "packet", because
> there is no need to use a non-default address map.
> * Add missing interrupt related properties.
> * Drop "adi,input-*" properties which are only valid for adv751*.
> * Add VEXT_3V3 fixed regulator.
> * Add "*-supply" properties, since most are required.
> * Fix label names - s/adv7533/adv7535/.
>
> Fixes: 65344b9bed3a ("arm64: dts: imx8mp-evk: Add HDMI support")
> Signed-off-by: Liu Ying <[email protected]>

Applied, thanks!