Commit e8e8a0c6c9bfc ("writeback: move nr_pages == 0 logic to one
location") removed parameter nr_pages of __wakeup_flusher_threads_bdi
and we try to writeback all dirty pages in __wakeup_flusher_threads_bdi
now. Just correct stale comment.
Signed-off-by: Kemeng Shi <[email protected]>
---
fs/fs-writeback.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index e8868e814e0a..816505d74b2f 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2345,8 +2345,7 @@ void wb_workfn(struct work_struct *work)
}
/*
- * Start writeback of `nr_pages' pages on this bdi. If `nr_pages' is zero,
- * write back the whole world.
+ * Start writeback of all dirty pages on this bdi.
*/
static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,
enum wb_reason reason)
--
2.30.0
On Fri 09-02-24 01:20:23, Kemeng Shi wrote:
> Commit e8e8a0c6c9bfc ("writeback: move nr_pages == 0 logic to one
> location") removed parameter nr_pages of __wakeup_flusher_threads_bdi
> and we try to writeback all dirty pages in __wakeup_flusher_threads_bdi
> now. Just correct stale comment.
>
> Signed-off-by: Kemeng Shi <[email protected]>
Nice. Feel free to add:
Reviewed-by: Jan Kara <[email protected]>
Honza
> ---
> fs/fs-writeback.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index e8868e814e0a..816505d74b2f 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2345,8 +2345,7 @@ void wb_workfn(struct work_struct *work)
> }
>
> /*
> - * Start writeback of `nr_pages' pages on this bdi. If `nr_pages' is zero,
> - * write back the whole world.
> + * Start writeback of all dirty pages on this bdi.
> */
> static void __wakeup_flusher_threads_bdi(struct backing_dev_info *bdi,
> enum wb_reason reason)
> --
> 2.30.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR