2024-02-21 09:00:41

by Kunwu Chan

Subject: [PATCH] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller

Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
to simplify the creation of SLAB caches.

Signed-off-by: Kunwu Chan <[email protected]>
---
drivers/bus/mhi/ep/main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
index 65fc1d738bec..7b61d384b2b6 100644
--- a/drivers/bus/mhi/ep/main.c
+++ b/drivers/bus/mhi/ep/main.c
@@ -1493,9 +1493,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
goto err_destroy_ev_ring_el_cache;
}

- mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
- sizeof(struct mhi_ep_ring_item), 0,
- 0, NULL);
+ mhi_cntrl->ring_item_cache = KMEM_CACHE(mhi_ep_ring_item, 0);
if (!mhi_cntrl->ev_ring_el_cache) {
ret = -ENOMEM;
goto err_destroy_tre_buf_cache;
--
2.39.2

2024-02-27 05:12:54

by Manivannan Sadhasivam

Subject: Re: [PATCH] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller

On Wed, Feb 21, 2024 at 04:59:37PM +0800, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
>

There are multiple instances of kmem_cache_create() in this driver. Could you
change them also?

- Mani

> Signed-off-by: Kunwu Chan <[email protected]>
> ---
> drivers/bus/mhi/ep/main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 65fc1d738bec..7b61d384b2b6 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1493,9 +1493,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> goto err_destroy_ev_ring_el_cache;
> }
>
> - mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> - sizeof(struct mhi_ep_ring_item), 0,
> - 0, NULL);
> + mhi_cntrl->ring_item_cache = KMEM_CACHE(mhi_ep_ring_item, 0);
> if (!mhi_cntrl->ev_ring_el_cache) {
> ret = -ENOMEM;
> goto err_destroy_tre_buf_cache;
> --
> 2.39.2
>
>

--
மணிவண்ணன் சதாசிவம்

2024-02-27 09:56:07

by Kunwu Chan

Subject: Re: [PATCH] bus: mhi: ep: Simplify the allocation of slab caches in mhi_ep_register_controller

Thanks for the reply.
> > On Wed, Feb 21, 2024 at 04:59:37PM +0800, Kunwu Chan wrote:
> > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> > to simplify the creation of SLAB caches.
> >
>
> There are multiple instances of kmem_cache_create() in this driver. Could you
> change them also?

Sure, I'll change all of them if possible in v2 patch.

>
> - Mani
>
> > Signed-off-by: Kunwu Chan <[email protected]>
> > ---
> > drivers/bus/mhi/ep/main.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> > index 65fc1d738bec..7b61d384b2b6 100644
> > --- a/drivers/bus/mhi/ep/main.c
> > +++ b/drivers/bus/mhi/ep/main.c
> > @@ -1493,9 +1493,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> > goto err_destroy_ev_ring_el_cache;
> > }
> >
> > - mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> > - sizeof(struct mhi_ep_ring_item), 0,
> > - 0, NULL);
> > + mhi_cntrl->ring_item_cache = KMEM_CACHE(mhi_ep_ring_item, 0);
> > if (!mhi_cntrl->ev_ring_el_cache) {
> > ret = -ENOMEM;
> > goto err_destroy_tre_buf_cache;
> > --
> > 2.39.2
> >
> >
>
> --
> மணிவண்ணன் சதாசிவம்
>
Thanks,
Kunwu.Chan