From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.
Signed-off-by: Chengming Zhou <[email protected]>
---
net/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index ed3df2f749bf..7e9c8fc9a5b4 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -343,7 +343,7 @@ static void init_inodecache(void)
0,
(SLAB_HWCACHE_ALIGN |
SLAB_RECLAIM_ACCOUNT |
- SLAB_MEM_SPREAD | SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
init_once);
BUG_ON(sock_inode_cachep == NULL);
}
--
2.40.1
On 2024/2/24 21:49, [email protected] wrote:
> From: Chengming Zhou <[email protected]>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete explicitly to avoid confusion
for users. Here we can just remove all its users, which has no any
functional change.
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
>
> Signed-off-by: Chengming Zhou <[email protected]>
> ---
> net/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/socket.c b/net/socket.c
> index ed3df2f749bf..7e9c8fc9a5b4 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -343,7 +343,7 @@ static void init_inodecache(void)
> 0,
> (SLAB_HWCACHE_ALIGN |
> SLAB_RECLAIM_ACCOUNT |
> - SLAB_MEM_SPREAD | SLAB_ACCOUNT),
> + SLAB_ACCOUNT),
> init_once);
> BUG_ON(sock_inode_cachep == NULL);
> }
On Mon, Feb 26, 2024 at 04:55:01PM +0800, Chengming Zhou wrote:
> On 2024/2/24 21:49, [email protected] wrote:
> > From: Chengming Zhou <[email protected]>
> >
> > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> > its usage so we can delete it from slab. No functional change.
>
> Update changelog to make it clearer:
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed as of v6.8-rc1, so it became a dead flag since the commit
> 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
> series[1] went on to mark it obsolete explicitly to avoid confusion
> for users. Here we can just remove all its users, which has no any
> functional change.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Thanks!
>
> >
> > Signed-off-by: Chengming Zhou <[email protected]>
Thanks Chengming Zhou,
this seems reasonable to me. But I think it would be best to post
a v2 of this patch with the updated patch description (which is very
helpful, BTW).
--
pw-bot: changes-requested