2024-02-27 21:46:08

by Chris Packham

Subject: [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530

The Allied Telesis x530 products have a 7 segment LED display which is
used for node identification when the devices are stacked. Represent
this as a gpio-7seg device.

Signed-off-by: Chris Packham <[email protected]>
---

Notes:
Changes in v2:
- Use compatible = "generic-gpio=7seg" to keep checkpatch.pl happy

arch/arm/boot/dts/marvell/armada-385-atl-x530.dts | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
index 5a9ab8410b7b..f55a3dc6b6de 100644
--- a/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
+++ b/arch/arm/boot/dts/marvell/armada-385-atl-x530.dts
@@ -43,6 +43,17 @@ uart0: serial@12000 {
};
};
};
+
+ led-7seg {
+ compatible = "generic-gpio-7seg";
+ segment-gpios = <&led_7seg_gpio 0 GPIO_ACTIVE_LOW
+ &led_7seg_gpio 1 GPIO_ACTIVE_LOW
+ &led_7seg_gpio 2 GPIO_ACTIVE_LOW
+ &led_7seg_gpio 3 GPIO_ACTIVE_LOW
+ &led_7seg_gpio 4 GPIO_ACTIVE_LOW
+ &led_7seg_gpio 5 GPIO_ACTIVE_LOW
+ &led_7seg_gpio 6 GPIO_ACTIVE_LOW>;
+ };
};

&pciec {
@@ -149,7 +160,7 @@ i2c@3 {
#size-cells = <0>;
reg = <3>;

- gpio@20 {
+ led_7seg_gpio: gpio@20 {
compatible = "nxp,pca9554";
gpio-controller;
#gpio-cells = <2>;
--
2.43.2

2024-02-28 00:56:22

by Andy Shevchenko

Subject: Re: [PATCH v2 3/4] ARM: dts: marvell: Add 7 segment LED display on x530

On Tue, Feb 27, 2024 at 11:22 PM Chris Packham
<[email protected]> wrote:
>
> The Allied Telesis x530 products have a 7 segment LED display which is
> used for node identification when the devices are stacked. Represent
> this as a gpio-7seg device.

Please, be consistent with naming and references. I think the
compatible / driver name are the only two that should be used.

This also needs an Ack from the respective maintainer (I don't know
who that is, you might find in MAINTAINERS, though).

--
With Best Regards,
Andy Shevchenko