Drop reference to the 25MHz clock as it has nothing to do with connecting
the PHY and the MAC.
Add info about the reference clock direction between the PHY and the MAC
as it depends on the selected rmii mode.
Suggested-by: Andrew Lunn <[email protected]>
Signed-off-by: Jérémie Dautheribes <[email protected]>
---
This patch follows on from my previous patch series [1] which has already been
merged into the net-next tree and which added the "ti,rmii-mode" property.
As suggested by Andrew Lunn, this patch updates the description of this
property to make it more consistent with the master/slave relationship it
conveys.
[1] https://lore.kernel.org/all/[email protected]/
Resending because I previously forgot to include the "net-next" entry in
the email subject.
Documentation/devicetree/bindings/net/ti,dp83822.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
index 8f23254c0458..784866ea392b 100644
--- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
+++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
@@ -84,10 +84,10 @@ properties:
description: |
If present, select the RMII operation mode. Two modes are
available:
- - RMII master, where the PHY operates from a 25MHz clock reference,
- provided by a crystal or a CMOS-level oscillator
- - RMII slave, where the PHY operates from a 50MHz clock reference,
- provided by a CMOS-level oscillator
+ - RMII master, where the PHY outputs a 50MHz reference clock which can
+ be connected to the MAC.
+ - RMII slave, where the PHY expects a 50MHz reference clock input
+ shared with the MAC.
The RMII operation mode can also be configured by its straps.
If the strap pin is not set correctly or not set at all, then this can be
used to configure it.
--
2.34.1
On Tue, Mar 05, 2024 at 03:13:09PM +0100, J?r?mie Dautheribes wrote:
> Drop reference to the 25MHz clock as it has nothing to do with connecting
> the PHY and the MAC.
> Add info about the reference clock direction between the PHY and the MAC
> as it depends on the selected rmii mode.
>
> Suggested-by: Andrew Lunn <[email protected]>
> Signed-off-by: J?r?mie Dautheribes <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Andrew
On Tue, Mar 05, 2024 at 03:13:09PM +0100, J?r?mie Dautheribes wrote:
> Drop reference to the 25MHz clock as it has nothing to do with connecting
> the PHY and the MAC.
> Add info about the reference clock direction between the PHY and the MAC
> as it depends on the selected rmii mode.
>
> Suggested-by: Andrew Lunn <[email protected]>
> Signed-off-by: J?r?mie Dautheribes <[email protected]>
This feels like it should have a Fixes: tag.
Otherwise
Acked-by: Conor Dooley <[email protected]>
Cheerrs,
Conor.
> ---
> This patch follows on from my previous patch series [1] which has already been
> merged into the net-next tree and which added the "ti,rmii-mode" property.
> As suggested by Andrew Lunn, this patch updates the description of this
> property to make it more consistent with the master/slave relationship it
> conveys.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Resending because I previously forgot to include the "net-next" entry in
> the email subject.
>
> Documentation/devicetree/bindings/net/ti,dp83822.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> index 8f23254c0458..784866ea392b 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> @@ -84,10 +84,10 @@ properties:
> description: |
> If present, select the RMII operation mode. Two modes are
> available:
> - - RMII master, where the PHY operates from a 25MHz clock reference,
> - provided by a crystal or a CMOS-level oscillator
> - - RMII slave, where the PHY operates from a 50MHz clock reference,
> - provided by a CMOS-level oscillator
> + - RMII master, where the PHY outputs a 50MHz reference clock which can
> + be connected to the MAC.
> + - RMII slave, where the PHY expects a 50MHz reference clock input
> + shared with the MAC.
> The RMII operation mode can also be configured by its straps.
> If the strap pin is not set correctly or not set at all, then this can be
> used to configure it.
> --
> 2.34.1
>
>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:
On Tue, 5 Mar 2024 15:13:09 +0100 you wrote:
> Drop reference to the 25MHz clock as it has nothing to do with connecting
> the PHY and the MAC.
> Add info about the reference clock direction between the PHY and the MAC
> as it depends on the selected rmii mode.
>
> Suggested-by: Andrew Lunn <[email protected]>
> Signed-off-by: Jérémie Dautheribes <[email protected]>
>
> [...]
Here is the summary with links:
- [RESEND,net-next] dt-bindings: net: dp83822: change ti,rmii-mode description
https://git.kernel.org/netdev/net-next/c/b72413211b48
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html