2024-03-10 11:22:10

by Stafford Horne

Subject: [PATCH] riscv: Remove unused asm/signal.h file

When riscv moved to common entry the definition and usage of
do_work_pending was removed. This unused header file remains.

Remove the header file as it is not used.

I have tested compiling the kernel with this patch applied and saw no
issues. Noticed when auditing how different ports handle signals
related to saving FPU state.

Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
Signed-off-by: Stafford Horne <[email protected]>
---
arch/riscv/include/asm/signal.h | 12 ------------
1 file changed, 12 deletions(-)
delete mode 100644 arch/riscv/include/asm/signal.h

diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
deleted file mode 100644
index 956ae0a01bad..000000000000
--- a/arch/riscv/include/asm/signal.h
+++ /dev/null
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#ifndef __ASM_SIGNAL_H
-#define __ASM_SIGNAL_H
-
-#include <uapi/asm/signal.h>
-#include <uapi/asm/ptrace.h>
-
-asmlinkage __visible
-void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
-
-#endif
--
2.41.0

2024-03-11 08:30:41

by Guo Ren

Subject: Re: [PATCH] riscv: Remove unused asm/signal.h file

On Sun, Mar 10, 2024 at 7:21 PM Stafford Horne <[email protected]> wrote:
>
> When riscv moved to common entry the definition and usage of
> do_work_pending was removed. This unused header file remains.
>
> Remove the header file as it is not used.
>
> I have tested compiling the kernel with this patch applied and saw no
> issues. Noticed when auditing how different ports handle signals
> related to saving FPU state.
>
> Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> Signed-off-by: Stafford Horne <[email protected]>
> ---
> arch/riscv/include/asm/signal.h | 12 ------------
> 1 file changed, 12 deletions(-)
> delete mode 100644 arch/riscv/include/asm/signal.h
>
> diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/signal.h
> deleted file mode 100644
> index 956ae0a01bad..000000000000
> --- a/arch/riscv/include/asm/signal.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -
> -#ifndef __ASM_SIGNAL_H
> -#define __ASM_SIGNAL_H
> -
> -#include <uapi/asm/signal.h>
> -#include <uapi/asm/ptrace.h>
> -
> -asmlinkage __visible
> -void do_work_pending(struct pt_regs *regs, unsigned long thread_info_flags);
No more calling in arch/riscv for do_work_pending.

> -
> -#endif
> --
> 2.41.0
>
LGTM, Thx.

Reviewed-by: Guo Ren <[email protected]>

--
Best Regards
Guo Ren