ret is assigned first, so it does not need to initialize the assignment.
Signed-off-by: Li zeming <[email protected]>
---
block/blk-zoned.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index d343e5756a9c8..6633e95bc7858 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -255,7 +255,7 @@ int blkdev_zone_mgmt(struct block_device *bdev, enum req_op op,
sector_t capacity = bdev_nr_sectors(bdev);
sector_t end_sector = sector + nr_sectors;
struct bio *bio = NULL;
- int ret = 0;
+ int ret;
if (!bdev_is_zoned(bdev))
return -EOPNOTSUPP;
--
2.18.2
On 3/17/24 19:55, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <[email protected]>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <[email protected]>
-ck
> ret is assigned first, so it does not need to initialize the assignment.
* Would a wording approach (like the following) be a bit nicer?
The variable “ret” will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
* How do you think about to use the summary phrase
“Delete an unnecessary initialisation in blkdev_zone_mgmt()”?
Regards,
Markus