2024-03-25 17:14:05

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] mtd: core: Align comment with an action in mtd_otp_nvmem_add()

Hi Andy,

[email protected] wrote on Mon, 25 Mar 2024 17:28:12
+0200:

> On Mon, Mar 25, 2024 at 05:11:50PM +0200, Andy Shevchenko wrote:
> > The comment is related to the non-error case, make it more clear
> > by inverting the condition. It also makes code neater at the end.
>
> Just realized that even semantically it's better as it's done here
> since we have an error path from which we exceptionally return successes
> (in some cases). Tell me if I need to add this to the commit message.
>

It's fine like that.

Thanks,
Miquèl