2024-03-26 14:14:36

by Raymond Hackley

Subject: [PATCH 0/2] arm64: dts: qcom: msm8916/8216-samsung-fortuna: Add samsung,fortuna binding

Add common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H (msm8216-samsung-fortuna3g)
- SM-G530W (msm8916-gprimeltecan)

2024-03-26 14:17:05

by Raymond Hackley

Subject: [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna

Document common binding samsung,fortuna used by the following
Samsung Galaxy Grand Prime devices below:
- SM-G530FZ (msm8916-samsung-grandprimelte)
- SM-G530H (msm8216-samsung-fortuna3g)
- SM-G530W (msm8916-gprimeltecan)

Signed-off-by: Raymond Hackley <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 66beaac60e1d..2db776d78d22 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -204,6 +204,7 @@ properties:
- samsung,a5u-eur
- samsung,e5
- samsung,e7
+ - samsung,fortuna
- samsung,fortuna3g
- samsung,gprimeltecan
- samsung,grandmax
--
2.39.2

2024-03-27 15:45:21

by Rob Herring (Arm)

Subject: Re: [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna

On Tue, Mar 26, 2024 at 02:12:58PM +0000, Raymond Hackley wrote:
> Document common binding samsung,fortuna used by the following
> Samsung Galaxy Grand Prime devices below:
> - SM-G530FZ (msm8916-samsung-grandprimelte)
> - SM-G530H (msm8216-samsung-fortuna3g)
> - SM-G530W (msm8916-gprimeltecan)

Commit messages should answer "why?". Why do you need this?

Please test this binding change against your dts changes. I think you
will find it fails.

>
> Signed-off-by: Raymond Hackley <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 66beaac60e1d..2db776d78d22 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -204,6 +204,7 @@ properties:
> - samsung,a5u-eur
> - samsung,e5
> - samsung,e7
> + - samsung,fortuna
> - samsung,fortuna3g
> - samsung,gprimeltecan
> - samsung,grandmax
> --
> 2.39.2
>
>