No functional modification involved.
mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead.
Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8659
Signed-off-by: Jiapeng Chong <[email protected]>
---
mm/slab_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 8664da88e843..8af45e9bd2b2 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
}
/**
- * krealloc - reallocate memory. The contents will remain unchanged.
+ * krealloc_noprof - reallocate memory. The contents will remain unchanged.
* @p: object to reallocate memory for.
* @new_size: how many bytes of memory are required.
* @flags: the type of memory to allocate.
--
2.20.1.7.g153144c
On 3/28/24 3:07 AM, Jiapeng Chong wrote:
> No functional modification involved.
>
> mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8659
> Signed-off-by: Jiapeng Chong <[email protected]>
Seems like a fix-up for the alloc tagging series in mm.
> ---
> mm/slab_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 8664da88e843..8af45e9bd2b2 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
> }
>
> /**
> - * krealloc - reallocate memory. The contents will remain unchanged.
> + * krealloc_noprof - reallocate memory. The contents will remain unchanged.
> * @p: object to reallocate memory for.
> * @new_size: how many bytes of memory are required.
> * @flags: the type of memory to allocate.
On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong <[email protected]> wrote:
> No functional modification involved.
>
> mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead.
>
> ...
>
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
> }
>
> /**
> - * krealloc - reallocate memory. The contents will remain unchanged.
> + * krealloc_noprof - reallocate memory. The contents will remain unchanged.
> * @p: object to reallocate memory for.
> * @new_size: how many bytes of memory are required.
> * @flags: the type of memory to allocate.
Well ok, but krealloc_noprof() is just an internal implementation
detail. I suggest this documentation be moved to the new krealloc()
wrapper site. Because krealloc() remains the thing which people
actually call.
Presumably the same applies to more of the new _noprof functions.
On Wed, Apr 3, 2024 at 6:23 PM Andrew Morton <akpm@linux-foundationorg> wrote:
>
> On Thu, 28 Mar 2024 10:07:11 +0800 Jiapeng Chong <[email protected]> wrote:
>
> > No functional modification involved.
> >
> > mm/slab_common.c:1215: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead.
> >
> > ...
> >
> > --- a/mm/slab_common.c
> > +++ b/mm/slab_common.c
> > @@ -1199,7 +1199,7 @@ __do_krealloc(const void *p, size_t new_size, gfp_t flags)
> > }
> >
> > /**
> > - * krealloc - reallocate memory. The contents will remain unchanged.
> > + * krealloc_noprof - reallocate memory. The contents will remain unchanged.
> > * @p: object to reallocate memory for.
> > * @new_size: how many bytes of memory are required.
> > * @flags: the type of memory to allocate.
Nack.
>
> Well ok, but krealloc_noprof() is just an internal implementation
> detail. I suggest this documentation be moved to the new krealloc()
> wrapper site. Because krealloc() remains the thing which people
> actually call.
>
> Presumably the same applies to more of the new _noprof functions.
We don't need this fixup. Randy Dunlap's change [1] should handle
_noprof suffixes correctly. The warning was likely generated because
his change was not yet picked up.
[1] https://lore.kernel.org/all/[email protected]/