This board is based on ti,j722s
https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai
Signed-off-by: Robert Nelson <[email protected]>
CC: Rob Herring <[email protected]>
CC: Nishanth Menon <[email protected]>
CC: Jared McArthur <[email protected]>
CC: Jason Kridner <[email protected]>
CC: Deepak Khatri <[email protected]>
---
Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
index 52b51fd7044e..ca23b7e6a35e 100644
--- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
+++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
@@ -134,6 +134,7 @@ properties:
- description: K3 J722S SoC and Boards
items:
- enum:
+ - beagle,j722s-beagley-ai
- ti,j722s-evm
- const: ti,j722s
--
2.39.2
BeagleBoard.org BeagleY-AI is an easy to use, affordable open source
hardware single board computer based on the Texas Instruments AM67A,
which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose
digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA),
GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5
cores for low-power, low-latency GPIO control.
https://beagley-ai.org/
https://openbeagle.org/beagley-ai/beagley-ai
Signed-off-by: Robert Nelson <[email protected]>
CC: Nishanth Menon <[email protected]>
CC: Jared McArthur <[email protected]>
CC: Jason Kridner <[email protected]>
CC: Deepak Khatri <[email protected]>
---
arch/arm64/boot/dts/ti/Makefile | 1 +
.../arm64/boot/dts/ti/k3-j722s-beagley-ai.dts | 373 ++++++++++++++++++
2 files changed, 374 insertions(+)
create mode 100644 arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dts
diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
index 9a722c2473fb..c76b41f86527 100644
--- a/arch/arm64/boot/dts/ti/Makefile
+++ b/arch/arm64/boot/dts/ti/Makefile
@@ -95,6 +95,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-pcie1-ep.dtbo
# Boards with J722s SoC
+dtb-$(CONFIG_ARCH_K3) += k3-j722s-beagley-ai.dtb
dtb-$(CONFIG_ARCH_K3) += k3-j722s-evm.dtb
# Boards with J784s4 SoC
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dts b/arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dts
new file mode 100644
index 000000000000..a6e5a4243bef
--- /dev/null
+++ b/arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dts
@@ -0,0 +1,373 @@
+// SPDX-License-Identifier: GPL-2.0-only OR MIT
+/*
+ * https://beagley-ai.org/
+ *
+ * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/
+ * Copyright (C) 2024 Robert Nelson, BeagleBoard.org Foundation
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/net/ti-dp83867.h>
+#include "k3-j722s.dtsi"
+
+/ {
+ compatible = "beagle,j722s-beagley-ai", "ti,j722s";
+ model = "BeagleBoard.org BeagleY-AI";
+
+ aliases {
+ serial0 = &wkup_uart0;
+ serial2 = &main_uart0;
+ mmc0 = &sdhci1;
+ };
+
+ chosen {
+ stdout-path = &main_uart0;
+ };
+
+ memory@80000000 {
+ /* 4G RAM */
+ reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
+ <0x00000008 0x80000000 0x00000000 0x80000000>;
+ device_type = "memory";
+ bootph-pre-ram;
+ };
+
+ reserved_memory: reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ secure_tfa_ddr: tfa@9e780000 {
+ reg = <0x00 0x9e780000 0x00 0x80000>;
+ no-map;
+ };
+
+ secure_ddr: optee@9e800000 {
+ reg = <0x00 0x9e800000 0x00 0x01800000>;
+ no-map;
+ };
+
+ wkup_r5fss0_core0_memory_region: r5f-memory@a0100000 {
+ compatible = "shared-dma-pool";
+ reg = <0x00 0xa0100000 0x00 0xf00000>;
+ no-map;
+ };
+
+ };
+
+ vsys_5v0: regulator-1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys_5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ bootph-all;
+ };
+
+ vdd_3v3: regulator-2 {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_3v3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vsys_5v0>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ vdd_mmc1: regulator-mmc1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_mmc1";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_3v3_sd_pins_default>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ enable-active-high;
+ gpio = <&main_gpio1 50 GPIO_ACTIVE_HIGH>;
+ bootph-all;
+ };
+
+ vdd_sd_dv: regulator-TLV71033 {
+ compatible = "regulator-gpio";
+ regulator-name = "tlv71033";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_sd_dv_pins_default>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ vin-supply = <&vsys_5v0>;
+ gpios = <&main_gpio1 49 GPIO_ACTIVE_HIGH>;
+ states = <1800000 0x0>,
+ <3300000 0x1>;
+ };
+
+ vsys_io_1v8: regulator-vsys-io-1v8 {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys_io_1v8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ vsys_io_1v2: regulator-vsys-io-1v2 {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys_io_1v2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&main_pmx0 {
+
+ main_i2c0_pins_default: main-i2c0-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D23) I2C0_SCL */
+ J722S_IOPAD(0x01e4, PIN_INPUT_PULLUP, 0) /* (B22) I2C0_SDA */
+ >;
+ bootph-all;
+ };
+
+ main_uart0_pins_default: main-uart0-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x01c8, PIN_INPUT, 0) /* (A22) UART0_RXD */
+ J722S_IOPAD(0x01cc, PIN_OUTPUT, 0) /* (B22) UART0_TXD */
+ >;
+ bootph-all;
+ };
+
+ vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x0244, PIN_OUTPUT, 7) /* (A24) MMC1_SDWP.GPIO1_49 */
+ >;
+ bootph-all;
+ };
+
+ main_mmc1_pins_default: main-mmc1-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x023c, PIN_INPUT, 0) /* (H22) MMC1_CMD */
+ J722S_IOPAD(0x0234, PIN_OUTPUT, 0) /* (H24) MMC1_CLK */
+ J722S_IOPAD(0x0230, PIN_INPUT, 0) /* (H23) MMC1_DAT0 */
+ J722S_IOPAD(0x022c, PIN_INPUT_PULLUP, 0) /* (H20) MMC1_DAT1 */
+ J722S_IOPAD(0x0228, PIN_INPUT_PULLUP, 0) /* (J23) MMC1_DAT2 */
+ J722S_IOPAD(0x0224, PIN_INPUT_PULLUP, 0) /* (H25) MMC1_DAT3 */
+ J722S_IOPAD(0x0240, PIN_INPUT, 0) /* (B24) MMC1_SDCD */
+ >;
+ bootph-all;
+ };
+
+ mdio_pins_default: mdio-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x0160, PIN_OUTPUT, 0) /* (AC24) MDIO0_MDC */
+ J722S_IOPAD(0x015c, PIN_INPUT, 0) /* (AD25) MDIO0_MDIO */
+ >;
+ };
+
+ rgmii1_pins_default: rgmii1-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x014c, PIN_INPUT, 0) /* (AC25) RGMII1_RD0 */
+ J722S_IOPAD(0x0150, PIN_INPUT, 0) /* (AD27) RGMII1_RD1 */
+ J722S_IOPAD(0x0154, PIN_INPUT, 0) /* (AE24) RGMII1_RD2 */
+ J722S_IOPAD(0x0158, PIN_INPUT, 0) /* (AE26) RGMII1_RD3 */
+ J722S_IOPAD(0x0148, PIN_INPUT, 0) /* (AE27) RGMII1_RXC */
+ J722S_IOPAD(0x0144, PIN_INPUT, 0) /* (AD23) RGMII1_RX_CTL */
+ J722S_IOPAD(0x0134, PIN_OUTPUT, 0) /* (AF27) RGMII1_TD0 */
+ J722S_IOPAD(0x0138, PIN_OUTPUT, 0) /* (AE23) RGMII1_TD1 */
+ J722S_IOPAD(0x013c, PIN_OUTPUT, 0) /* (AG25) RGMII1_TD2 */
+ J722S_IOPAD(0x0140, PIN_OUTPUT, 0) /* (AF24) RGMII1_TD3 */
+ J722S_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AG26) RGMII1_TXC */
+ J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */
+ >;
+ };
+
+ pmic_irq_pins_default: pmic-irq-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x01f4, PIN_INPUT_PULLUP, 0) /* (B23) EXTINTn */
+ >;
+ };
+
+ vdd_3v3_sd_pins_default: vdd-3v3-sd-pins-default {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x0254, PIN_OUTPUT, 7) /* (E25) USB0_DRVVBUS.GPIO1_50 */
+ >;
+ };
+};
+
+&cpsw3g {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&rgmii1_pins_default>, <&gbe_pmx_obsclk>;
+
+ assigned-clocks = <&k3_clks 227 0>;
+ assigned-clock-parents = <&k3_clks 227 6>;
+};
+
+&cpsw3g_mdio {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&mdio_pins_default>;
+
+ cpsw3g_phy0: ethernet-phy@0 {
+ reg = <0>;
+ ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
+ ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
+ ti,min-output-impedance;
+ };
+};
+
+&cpsw_port1 {
+ phy-mode = "rgmii-rxid";
+ phy-handle = <&cpsw3g_phy0>;
+};
+
+&cpsw_port2 {
+ status = "disabled";
+};
+
+&main_gpio1 {
+ status = "okay";
+};
+
+&main_uart0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&main_uart0_pins_default>;
+ status = "okay";
+ bootph-all;
+};
+
+&mcu_pmx0 {
+
+ wkup_uart0_pins_default: wkup-uart0-default-pins {
+ pinctrl-single,pins = <
+ J722S_MCU_IOPAD(0x02c, PIN_INPUT, 0) /* (C7) WKUP_UART0_CTSn */
+ J722S_MCU_IOPAD(0x030, PIN_OUTPUT, 0) /* (C6) WKUP_UART0_RTSn */
+ J722S_MCU_IOPAD(0x024, PIN_INPUT, 0) /* (D8) WKUP_UART0_RXD */
+ J722S_MCU_IOPAD(0x028, PIN_OUTPUT, 0) /* (D7) WKUP_UART0_TXD */
+ >;
+ bootph-all;
+ };
+
+ wkup_i2c0_pins_default: wkup-i2c0-default-pins {
+ pinctrl-single,pins = <
+ J722S_MCU_IOPAD(0x04c, PIN_INPUT_PULLUP, 0) /* (C7) WKUP_I2C0_SCL */
+ J722S_MCU_IOPAD(0x050, PIN_INPUT_PULLUP, 0) /* (C6) WKUP_I2C1_SDA */
+ >;
+ bootph-all;
+ };
+
+ gbe_pmx_obsclk: gbe-pmx-obsclk-default-pins {
+ pinctrl-single,pins = <
+ J722S_MCU_IOPAD(0x0004, PIN_OUTPUT, 1) /* (A10) MCU_SPI0_CS1.MCU_OBSCLK0 */
+ >;
+ };
+};
+
+&wkup_uart0 {
+ /* WKUP UART0 is used by Device Manager firmware */
+ pinctrl-names = "default";
+ pinctrl-0 = <&wkup_uart0_pins_default>;
+ status = "reserved";
+ bootph-all;
+};
+
+&wkup_i2c0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&wkup_i2c0_pins_default>;
+ clock-frequency = <400000>;
+ status = "okay";
+ bootph-all;
+
+ tps65219: pmic@30 {
+ bootph-all;
+ compatible = "ti,tps65219";
+ reg = <0x30>;
+ buck1-supply = <&vsys_5v0>;
+ buck2-supply = <&vsys_5v0>;
+ buck3-supply = <&vsys_5v0>;
+ ldo1-supply = <&vdd_3v3>;
+ ldo3-supply = <&vdd_3v3>;
+ ldo4-supply = <&vdd_3v3>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_irq_pins_default>;
+ interrupt-parent = <&gic500>;
+ interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ system-power-controller;
+ ti,power-button;
+
+ regulators {
+ buck1_reg: buck1 {
+ regulator-name = "VDD_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck2_reg: buck2 {
+ regulator-name = "VDD_1V8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ buck3_reg: buck3 {
+ regulator-name = "VDD_1V1";
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1_reg: ldo1 {
+ regulator-name = "VDDSHV5_SDIO";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-allow-bypass;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo2_reg: ldo2 {
+ //Regulator is left as is unused.
+ };
+
+ ldo3_reg: ldo3 {
+ regulator-name = "VDDA_PHY_1V8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo4_reg: ldo4 {
+ regulator-name = "VDDA_PLL_1V8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ };
+};
+
+&sdhci1 {
+ /* SD/MMC */
+ vmmc-supply = <&vdd_mmc1>;
+ vqmmc-supply = <&vdd_sd_dv>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&main_mmc1_pins_default>;
+ ti,driver-strength-ohm = <50>;
+ disable-wp;
+ no-1-8-v;
+ status = "okay";
+ bootph-all;
+};
--
2.39.2
On Thu, Mar 28, 2024 at 2:12 PM Robert Nelson <[email protected]> wrote:
>
> BeagleBoard.org BeagleY-AI is an easy to use, affordable open source
> hardware single board computer based on the Texas Instruments AM67A,
> which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose
> digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA),
> GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5
> cores for low-power, low-latency GPIO control.
>
> https://beagley-ai.org/
> https://openbeagle.org/beagley-ai/beagley-ai
@Jason Kridner we need this to become public when you are ready ^ ;)
Boot log:
https://gist.github.com/RobertCNelson/9db8ea04848e7ce2ca52c038fab0e1b7
--
Robert Nelson
https://rcn-ee.com/
> On Mar 28, 2024, at 9:16 AM, Robert Nelson <[email protected]> wrote:
>
> On Thu, Mar 28, 2024 at 2:12 PM Robert Nelson <[email protected]> wrote:
>>
>> BeagleBoard.org BeagleY-AI is an easy to use, affordable open source
>> hardware single board computer based on the Texas Instruments AM67A,
>> which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose
>> digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA),
>> GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5
>> cores for low-power, low-latency GPIO control.
>>
>> https://beagley-ai.org/
>> https://openbeagle.org/beagley-ai/beagley-ai
>
> @Jason Kridner we need this to become public when you are ready ^ ;)
>
Did I mess up? Should already be public. We should make a github.com mirror though for up-time/visibility/bandwidth.
> Boot log:
>
> https://gist.github.com/RobertCNelson/9db8ea04848e7ce2ca52c038fab0e1b7
>
> --
> Robert Nelson
> https://rcn-ee.com/
On Thu, Mar 28, 2024 at 2:26 PM Jason Kridner <jkridner@beagleboardorg> wrote:
>
>
>
> > On Mar 28, 2024, at 9:16 AM, Robert Nelson <robertcnelson@gmailcom> wrote:
> >
> > On Thu, Mar 28, 2024 at 2:12 PM Robert Nelson <[email protected]> wrote:
> >>
> >> BeagleBoard.org BeagleY-AI is an easy to use, affordable open source
> >> hardware single board computer based on the Texas Instruments AM67A,
> >> which features a quad-core 64-bit Arm CPU subsystem, 2 general-purpose
> >> digital-signal-processors (DSP) and matrix-multiply-accelerators (MMA),
> >> GPU, vision and deep learning accelerators, and multiple Arm Cortex-R5
> >> cores for low-power, low-latency GPIO control.
> >>
> >> https://beagley-ai.org/
> >> https://openbeagle.org/beagley-ai/beagley-ai
> >
> > @Jason Kridner we need this to become public when you are ready ^ ;)
> >
>
> Did I mess up? Should already be public. We should make a github.com mirror though for up-time/visibility/bandwidth.
Thanks Jason, it seems to work in incognito mode now, so we are good!
Regards,
--
Robert Nelson
https://rcn-ee.com/
On Thu, 28 Mar 2024 14:12:04 -0500, Robert Nelson wrote:
> This board is based on ti,j722s
>
> https://beagley-ai.org/
> https://openbeagle.org/beagley-ai/beagley-ai
>
> Signed-off-by: Robert Nelson <[email protected]>
> CC: Rob Herring <[email protected]>
> CC: Nishanth Menon <[email protected]>
> CC: Jared McArthur <[email protected]>
> CC: Jason Kridner <[email protected]>
> CC: Deepak Khatri <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y ti/k3-j722s-beagley-ai.dtb' for [email protected]:
arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dtb: pinctrl@f4000: 'vdd-3v3-sd-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-single.yaml#
On Thu, 28 Mar 2024 14:12:04 -0500, Robert Nelson wrote:
> This board is based on ti,j722s
>
> https://beagley-ai.org/
> https://openbeagle.org/beagley-ai/beagley-ai
>
> Signed-off-by: Robert Nelson <[email protected]>
> CC: Rob Herring <[email protected]>
> CC: Nishanth Menon <[email protected]>
> CC: Jared McArthur <[email protected]>
> CC: Jason Kridner <[email protected]>
> CC: Deepak Khatri <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
Hi Robert Nelson,
On Thu, 28 Mar 2024 14:12:04 -0500, Robert Nelson wrote:
> This board is based on ti,j722s
>
> https://beagley-ai.org/
> https://openbeagle.org/beagley-ai/beagley-ai
>
>
Robert,
I did a couple of sync as part of rebase - but for the future, please
be aware of [2]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/2] dt-bindings: arm: ti: Add BeagleY-AI
commit: d2b3e3b544d7e657406db3bdcdc296f02f4f07c9
[2/2] arm64: dts: ti: Add k3-j722s-beagley-ai
commit: f6a61274cc851e1dbae82b5fa2d3e7087dccf85b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
[2] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 3/28/24 2:12 PM, Robert Nelson wrote:
> This board is based on ti,j722s
>
> https://beagley-ai.org/
> https://openbeagle.org/beagley-ai/beagley-ai
>
> Signed-off-by: Robert Nelson <[email protected]>
> CC: Rob Herring <[email protected]>
> CC: Nishanth Menon <[email protected]>
> CC: Jared McArthur <[email protected]>
> CC: Jason Kridner <[email protected]>
> CC: Deepak Khatri <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index 52b51fd7044e..ca23b7e6a35e 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -134,6 +134,7 @@ properties:
> - description: K3 J722S SoC and Boards
> items:
> - enum:
> + - beagle,j722s-beagley-ai
Recommend "beagle,am67-beagley-ai". The "J722s" is the family
name, the part used on this board is the AM67. We do the same
for the SK boards, for example, the SK-AM69 uses the AM69
part from the J784s4 family, so it is called k3-am69-sk.dts
with compatible = "ti,am69-sk", "ti,j784s4";
This would otherwise be the first board with a specific part
attached but uses the SoC family name instead of that specific
part name in the DT file/name. Only the EVMs should have the
family name since we sell versions of those with all the different
parts swapped onto it. I don't imagine you will be selling
BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your
docs and other collateral use "AM67", using the same here
would help avoid confusion.
Andrew
> - ti,j722s-evm
> - const: ti,j722s
>
On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <[email protected]> wrote:
>
> On 3/28/24 2:12 PM, Robert Nelson wrote:
> > This board is based on ti,j722s
> >
> > https://beagley-ai.org/
> > https://openbeagle.org/beagley-ai/beagley-ai
> >
> > Signed-off-by: Robert Nelson <[email protected]>
> > CC: Rob Herring <[email protected]>
> > CC: Nishanth Menon <[email protected]>
> > CC: Jared McArthur <[email protected]>
> > CC: Jason Kridner <[email protected]>
> > CC: Deepak Khatri <[email protected]>
> > ---
> > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > index 52b51fd7044e..ca23b7e6a35e 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > @@ -134,6 +134,7 @@ properties:
> > - description: K3 J722S SoC and Boards
> > items:
> > - enum:
> > + - beagle,j722s-beagley-ai
>
> Recommend "beagle,am67-beagley-ai". The "J722s" is the family
> name, the part used on this board is the AM67. We do the same
> for the SK boards, for example, the SK-AM69 uses the AM69
> part from the J784s4 family, so it is called k3-am69-sk.dts
> with compatible = "ti,am69-sk", "ti,j784s4";
>
> This would otherwise be the first board with a specific part
> attached but uses the SoC family name instead of that specific
> part name in the DT file/name. Only the EVMs should have the
> family name since we sell versions of those with all the different
> parts swapped onto it. I don't imagine you will be selling
> BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your
> docs and other collateral use "AM67", using the same here
> would help avoid confusion.
>
> Andrew
Andrew, would you like us to model this just like the AM69-SK? and
also rename the device tree? or just the bindings..
k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a
k3-am67a-beagley-ai.dtb ?
Regards,
--
Robert Nelson
https://rcn-ee.com/
On 14:48-20240423, Robert Nelson wrote:
> On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <[email protected]> wrote:
> >
> > On 3/28/24 2:12 PM, Robert Nelson wrote:
> > > This board is based on ti,j722s
> > >
> > > https://beagley-ai.org/
> > > https://openbeagle.org/beagley-ai/beagley-ai
> > >
> > > Signed-off-by: Robert Nelson <[email protected]>
> > > CC: Rob Herring <[email protected]>
> > > CC: Nishanth Menon <[email protected]>
> > > CC: Jared McArthur <[email protected]>
> > > CC: Jason Kridner <[email protected]>
> > > CC: Deepak Khatri <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > index 52b51fd7044e..ca23b7e6a35e 100644
> > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > @@ -134,6 +134,7 @@ properties:
> > > - description: K3 J722S SoC and Boards
> > > items:
> > > - enum:
> > > + - beagle,j722s-beagley-ai
> >
> > Recommend "beagle,am67-beagley-ai". The "J722s" is the family
> > name, the part used on this board is the AM67. We do the same
> > for the SK boards, for example, the SK-AM69 uses the AM69
> > part from the J784s4 family, so it is called k3-am69-sk.dts
> > with compatible = "ti,am69-sk", "ti,j784s4";
> >
> > This would otherwise be the first board with a specific part
> > attached but uses the SoC family name instead of that specific
> > part name in the DT file/name. Only the EVMs should have the
> > family name since we sell versions of those with all the different
> > parts swapped onto it. I don't imagine you will be selling
> > BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your
> > docs and other collateral use "AM67", using the same here
> > would help avoid confusion.
> >
> > Andrew
>
> Andrew, would you like us to model this just like the AM69-SK? and
> also rename the device tree? or just the bindings..
>
> k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a
> k3-am67a-beagley-ai.dtb ?
>
Will drop these patches off the queue for now. please respin as needed.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On 4/23/24 2:48 PM, Robert Nelson wrote:
> On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <[email protected]> wrote:
>>
>> On 3/28/24 2:12 PM, Robert Nelson wrote:
>>> This board is based on ti,j722s
>>>
>>> https://beagley-ai.org/
>>> https://openbeagle.org/beagley-ai/beagley-ai
>>>
>>> Signed-off-by: Robert Nelson <[email protected]>
>>> CC: Rob Herring <[email protected]>
>>> CC: Nishanth Menon <[email protected]>
>>> CC: Jared McArthur <[email protected]>
>>> CC: Jason Kridner <[email protected]>
>>> CC: Deepak Khatri <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> index 52b51fd7044e..ca23b7e6a35e 100644
>>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
>>> @@ -134,6 +134,7 @@ properties:
>>> - description: K3 J722S SoC and Boards
>>> items:
>>> - enum:
>>> + - beagle,j722s-beagley-ai
>>
>> Recommend "beagle,am67-beagley-ai". The "J722s" is the family
>> name, the part used on this board is the AM67. We do the same
>> for the SK boards, for example, the SK-AM69 uses the AM69
>> part from the J784s4 family, so it is called k3-am69-sk.dts
>> with compatible = "ti,am69-sk", "ti,j784s4";
>>
>> This would otherwise be the first board with a specific part
>> attached but uses the SoC family name instead of that specific
>> part name in the DT file/name. Only the EVMs should have the
>> family name since we sell versions of those with all the different
>> parts swapped onto it. I don't imagine you will be selling
>> BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your
>> docs and other collateral use "AM67", using the same here
>> would help avoid confusion.
>>
>> Andrew
>
> Andrew, would you like us to model this just like the AM69-SK? and
> also rename the device tree? or just the bindings..
>
> k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a
> k3-am67a-beagley-ai.dtb ?
>
Yes, rename binding and dtb name would be great. Better now then have
the name confuse folks forever.
AM67A is more correct than AM67 (which is the spin without AI), given
this is an AI focused device I'd imagine you'll be using the "a" version.
Andrew
> Regards,
>