2024-04-02 22:50:32

by Colberg, Peter

Subject: [PATCH] fpga: dfl: remove unused function is_dfl_feature_present

The function is_dfl_feature_present was added in commit 5b57d02a2f94
("fpga: dfl: add feature device infrastructure") but never used.

Signed-off-by: Peter Colberg <[email protected]>
Reviewed-by: Matthew Gerlach <[email protected]>
---
drivers/fpga/dfl.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
index 1d724a28f00a..5063d73b0d82 100644
--- a/drivers/fpga/dfl.h
+++ b/drivers/fpga/dfl.h
@@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
return NULL;
}

-static inline bool is_dfl_feature_present(struct device *dev, u16 id)
-{
- return !!dfl_get_feature_ioaddr_by_id(dev, id);
-}
-
static inline
struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
{
--
2.44.0

2024-04-13 03:44:24

by Xu Yilun

Subject: Re: [PATCH] fpga: dfl: remove unused function is_dfl_feature_present

On Tue, Apr 02, 2024 at 06:20:38PM -0400, Peter Colberg wrote:
> The function is_dfl_feature_present was added in commit 5b57d02a2f94
> ("fpga: dfl: add feature device infrastructure") but never used.

Same git commit reference problem, please see:

https://lore.kernel.org/all/Zhn8bjex94DpkGBw@yilunxu-OptiPlex-7050/

Thanks,
Yilun

>
> Signed-off-by: Peter Colberg <[email protected]>
> Reviewed-by: Matthew Gerlach <[email protected]>
> ---
> drivers/fpga/dfl.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 1d724a28f00a..5063d73b0d82 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -437,11 +437,6 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
> return NULL;
> }
>
> -static inline bool is_dfl_feature_present(struct device *dev, u16 id)
> -{
> - return !!dfl_get_feature_ioaddr_by_id(dev, id);
> -}
> -
> static inline
> struct device *dfl_fpga_pdata_to_parent(struct dfl_feature_platform_data *pdata)
> {
> --
> 2.44.0
>
>