2024-04-07 02:28:27

by Jiapeng Chong

Subject: [PATCH] HID: Remove the unused variable minor

Variable minor is not effectively used, so delete it.

drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/hid/hid-winwing.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/hid/hid-winwing.c b/drivers/hid/hid-winwing.c
index d895c82a541d..0e224d1a6466 100644
--- a/drivers/hid/hid-winwing.c
+++ b/drivers/hid/hid-winwing.c
@@ -120,7 +120,6 @@ static int winwing_init_led(struct hid_device *hdev,
static int winwing_probe(struct hid_device *hdev,
const struct hid_device_id *id)
{
- unsigned int minor;
int ret;

ret = hid_parse(hdev);
@@ -135,8 +134,6 @@ static int winwing_probe(struct hid_device *hdev,
return ret;
}

- minor = ((struct hidraw *) hdev->hidraw)->minor;
-
return 0;
}

--
2.20.1.7.g153144c

2024-04-12 11:38:38

by Jiri Kosina

Subject: Re: [PATCH] HID: Remove the unused variable minor

On Sun, 7 Apr 2024, Jiapeng Chong wrote:

> Variable minor is not effectively used, so delete it.
>
> drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705
> Signed-off-by: Jiapeng Chong <[email protected]>

I've added

Fixes: 266c990debad2 ("HID: Add WinWing Orion2 throttle support")

CCed Ivan here, and applied. Thanks,

--
Jiri Kosina
SUSE Labs