Adds driver and tool support for a new "current" meter that allows reading
the most current, but not attested, value of the meter counters. Also adds
fixes for the intel_sdsi tool.
David E. Box (8):
platform/x86/intel/sdsi: Set message size during writes
platform/x86/intel/sdsi: Combine read and write mailbox flows
platform/x86/intel/sdsi: Add attribute to read the current meter state
tools/arch/x86/intel_sdsi: Fix maximum meter bundle length
tools/arch/x86/intel_sdsi: Fix meter_show display
tools/arch/x86/intel_sdsi: Fix meter_certificate decoding
platform/x86/intel/sdsi: Simplify ascii printing
tools: intel_sdsi: Add current meter support
Kuppuswamy Sathyanarayanan (1):
platform/x86/intel/sdsi: Add in-band BIOS lock support
drivers/platform/x86/intel/sdsi.c | 118 ++++++++++++++++---------
tools/arch/x86/intel_sdsi/intel_sdsi.c | 108 +++++++++++++---------
2 files changed, 144 insertions(+), 82 deletions(-)
base-commit: 4cece764965020c22cff7665b18a012006359095
--
2.34.1
New mailbox commands will support sending multi packet writes and updated
firmware now requires that the message size be written for all commands
along with the packet size. Since the driver doesn't perform writes larger
than the packet size, set the message size to the same value.
Signed-off-by: David E. Box <[email protected]>
Reviewed-by: Ilpo Järvinen <[email protected]>
---
V4 - no changes
V3 - no changes
V2 - no changes
drivers/platform/x86/intel/sdsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
index 556e7c6dbb05..a70c071de6e2 100644
--- a/drivers/platform/x86/intel/sdsi.c
+++ b/drivers/platform/x86/intel/sdsi.c
@@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in
FIELD_PREP(CTRL_SOM, 1) |
FIELD_PREP(CTRL_RUN_BUSY, 1) |
FIELD_PREP(CTRL_READ_WRITE, 1) |
+ FIELD_PREP(CTRL_MSG_SIZE, info->size) |
FIELD_PREP(CTRL_PACKET_SIZE, info->size);
writeq(control, priv->control_addr);
--
2.34.1
Hi,
On 4/11/24 4:58 AM, David E. Box wrote:
> Adds driver and tool support for a new "current" meter that allows reading
> the most current, but not attested, value of the meter counters. Also adds
> fixes for the intel_sdsi tool.
>
> David E. Box (8):
> platform/x86/intel/sdsi: Set message size during writes
> platform/x86/intel/sdsi: Combine read and write mailbox flows
> platform/x86/intel/sdsi: Add attribute to read the current meter state
> tools/arch/x86/intel_sdsi: Fix maximum meter bundle length
> tools/arch/x86/intel_sdsi: Fix meter_show display
> tools/arch/x86/intel_sdsi: Fix meter_certificate decoding
> platform/x86/intel/sdsi: Simplify ascii printing
> tools: intel_sdsi: Add current meter support
Note the subject prefixes of these last 2 are wrong and should
both have been "tools/arch/x86/intel_sdsi" I have fixed this
up while merging this series:
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
>
> Kuppuswamy Sathyanarayanan (1):
> platform/x86/intel/sdsi: Add in-band BIOS lock support
>
> drivers/platform/x86/intel/sdsi.c | 118 ++++++++++++++++---------
> tools/arch/x86/intel_sdsi/intel_sdsi.c | 108 +++++++++++++---------
> 2 files changed, 144 insertions(+), 82 deletions(-)
>
>
> base-commit: 4cece764965020c22cff7665b18a012006359095