LinuxLists.cc - [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-11 03:38:12

Subject: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

Under different applications, the MT8188 SCP can be used as single-core
or dual-core.

Signed-off-by: olivia.wen <[email protected]>
---
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index 507f98f..7e7b567 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -22,7 +22,7 @@ properties:
- mediatek,mt8192-scp
- mediatek,mt8195-scp
- mediatek,mt8195-scp-dual
-
+ - mediatek,mt8188-scp-dual
reg:
description:
Should contain the address ranges for memory regions SRAM, CFG, and,
@@ -195,6 +195,7 @@ allOf:
compatible:
enum:
- mediatek,mt8195-scp-dual
+ - mediatek,mt8188-scp-dual
then:
properties:
reg:
--
2.6.4

2024-04-11 06:07:43

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

On 11/04/2024 05:37, olivia.wen wrote:
> Under different applications, the MT8188 SCP can be used as single-core
> or dual-core.
>
> Signed-off-by: olivia.wen <[email protected]>

Are you sure you use full name, not email login as name?

> ---
> Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index 507f98f..7e7b567 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -22,7 +22,7 @@ properties:
> - mediatek,mt8192-scp
> - mediatek,mt8195-scp
> - mediatek,mt8195-scp-dual
> -
> + - mediatek,mt8188-scp-dual

Missing blank line, misordered.

> reg:
> description:
> Should contain the address ranges for memory regions SRAM, CFG, and,
> @@ -195,6 +195,7 @@ allOf:
> compatible:
> enum:
> - mediatek,mt8195-scp-dual
> + - mediatek,mt8188-scp-dual

Again, keep the order.

Best regards,
Krzysztof

2024-04-11 07:34:15

by AngeloGioacchino Del Regno

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

Il 11/04/24 05:37, olivia.wen ha scritto:
> Under different applications, the MT8188 SCP can be used as single-core
> or dual-core.
>
> Signed-off-by: olivia.wen <[email protected]>
> ---
> Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> index 507f98f..7e7b567 100644
> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> @@ -22,7 +22,7 @@ properties:
> - mediatek,mt8192-scp
> - mediatek,mt8195-scp
> - mediatek,mt8195-scp-dual
> -

Don't remove the blank line, it's there for readability.

> + - mediatek,mt8188-scp-dual

After addressing that comment,

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

> reg:
> description:
> Should contain the address ranges for memory regions SRAM, CFG, and,
> @@ -195,6 +195,7 @@ allOf:
> compatible:
> enum:
> - mediatek,mt8195-scp-dual
> + - mediatek,mt8188-scp-dual
> then:
> properties:
> reg:

2024-04-11 07:40:48

by AngeloGioacchino Del Regno

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto:
> Il 11/04/24 05:37, olivia.wen ha scritto:
>> Under different applications, the MT8188 SCP can be used as single-core
>> or dual-core.
>>
>> Signed-off-by: olivia.wen <[email protected]>
>> ---
>> Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> index 507f98f..7e7b567 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> @@ -22,7 +22,7 @@ properties:
>>         - mediatek,mt8192-scp
>>         - mediatek,mt8195-scp
>>         - mediatek,mt8195-scp-dual
>> -
>
> Don't remove the blank line, it's there for readability.
>
>> +      - mediatek,mt8188-scp-dual

Ah, sorry, one more comment. Please, keep the entries ordered by name.
8188 goes before 8195.

>
> After addressing that comment,
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
>
>>     reg:
>>       description:
>>         Should contain the address ranges for memory regions SRAM, CFG, and,
>> @@ -195,6 +195,7 @@ allOf:
>>           compatible:
>>             enum:
>>               - mediatek,mt8195-scp-dual
>> +            - mediatek,mt8188-scp-dual

same here.

>>       then:
>>         properties:
>>           reg:
>
>

2024-04-12 10:19:09

by Olivia Wen

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

Hi AngeloGioacchino,

On Thu, 2024-04-11 at 09:39 +0200, AngeloGioacchino Del Regno wrote:
> Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto:
> > Il 11/04/24 05:37, olivia.wen ha scritto:
> > > Under different applications, the MT8188 SCP can be used as
> > > single-core
> > > or dual-core.
> > >
> > > Signed-off-by: olivia.wen <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3
> > > ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > index 507f98f..7e7b567 100644
> > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > > @@ -22,7 +22,7 @@ properties:
> > > - mediatek,mt8192-scp
> > > - mediatek,mt8195-scp
> > > - mediatek,mt8195-scp-dual
> > > -
> >
> > Don't remove the blank line, it's there for readability.
> >
> > > + - mediatek,mt8188-scp-dual
>
> Ah, sorry, one more comment. Please, keep the entries ordered by
> name.
> 8188 goes before 8195.
>
> >
> > After addressing that comment,
> >
> > Reviewed-by: AngeloGioacchino Del Regno <
> > [email protected]>
> >
> > > reg:
> > > description:
> > > Should contain the address ranges for memory regions
> > > SRAM, CFG, and,
> > > @@ -195,6 +195,7 @@ allOf:
> > > compatible:
> > > enum:
> > > - mediatek,mt8195-scp-dual
> > > + - mediatek,mt8188-scp-dual
>
> same here.
>
> > > then:
> > > properties:
> > > reg:
> >
> >
>

Thanks for the reviews.
It will be corrected in the next version.

Best regards,
Olivia

2024-04-12 11:01:07

by Olivia Wen

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

Hi Krzysztof,

Thanks for the reviews.

On Thu, 2024-04-11 at 08:06 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 11/04/2024 05:37, olivia.wen wrote:
> > Under different applications, the MT8188 SCP can be used as single-
> core
> > or dual-core.
> >
> > Signed-off-by: olivia.wen <[email protected]>
>
> Are you sure you use full name, not email login as name?
>

Thanks for the reminder. I have made changes.

> > ---
> > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index 507f98f..7e7b567 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -22,7 +22,7 @@ properties:
> > - mediatek,mt8192-scp
> > - mediatek,mt8195-scp
> > - mediatek,mt8195-scp-dual
> > -
> > + - mediatek,mt8188-scp-dual
>
> Missing blank line, misordered.
>

It will be corrected in the next version.

> > reg:
> > description:
> > Should contain the address ranges for memory regions SRAM,
> CFG, and,
> > @@ -195,6 +195,7 @@ allOf:
> > compatible:
> > enum:
> > - mediatek,mt8195-scp-dual
> > + - mediatek,mt8188-scp-dual
>
> Again, keep the order.
>

It will be corrected in the next version.

> Best regards,a
> Krzysztof
>
>

Best regards,
Olivia

2024-04-12 11:02:03

by Olivia Wen

[permalink] [raw]

Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP

2024-04-24 00:58:29

by Olivia Wen

[permalink] [raw]