2024-04-11 20:55:28

by Thorsten Blum

Subject: [PATCH] rust: helpers: Fix grammar in comment

s/directly the bindings/the bindings directly/

Signed-off-by: Thorsten Blum <[email protected]>
---
rust/helpers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/helpers.c b/rust/helpers.c
index 70e59efd92bc..4c8b7b92a4f4 100644
--- a/rust/helpers.c
+++ b/rust/helpers.c
@@ -4,7 +4,7 @@
* cannot be called either. This file explicitly creates functions ("helpers")
* that wrap those so that they can be called from Rust.
*
- * Even though Rust kernel modules should never use directly the bindings, some
+ * Even though Rust kernel modules should never use the bindings directly, some
* of these helpers need to be exported because Rust generics and inlined
* functions may not get their code generated in the crate where they are
* defined. Other helpers, called from non-inline functions, may not be
--
2.44.0

2024-04-12 11:05:55

by Alice Ryhl

Subject: Re: [PATCH] rust: helpers: Fix grammar in comment

On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <[email protected]> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <[email protected]>
> ---
> rust/helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 70e59efd92bc..4c8b7b92a4f4 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -4,7 +4,7 @@
> * cannot be called either. This file explicitly creates functions ("helpers")
> * that wrap those so that they can be called from Rust.
> *
> - * Even though Rust kernel modules should never use directly the bindings, some
> + * Even though Rust kernel modules should never use the bindings directly, some
> * of these helpers need to be exported because Rust generics and inlined
> * functions may not get their code generated in the crate where they are
> * defined. Other helpers, called from non-inline functions, may not be

Reviewed-by: Alice Ryhl <[email protected]>

2024-04-16 06:00:03

by Trevor Gross

Subject: Re: [PATCH] rust: helpers: Fix grammar in comment

On Thu, Apr 11, 2024 at 4:55 PM Thorsten Blum <thorsten.blum@tobluxcom> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <[email protected]>

Reviewed-by: Trevor Gross <[email protected]>

2024-05-05 22:29:39

by Miguel Ojeda

Subject: Re: [PATCH] rust: helpers: Fix grammar in comment

On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <[email protected]> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <[email protected]>

Applied to `rust-next` -- thanks everyone!

Cheers,
Miguel