2024-04-11 10:50:07

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.15 00/57] 5.15.155-rc1 review

This is the start of the stable review cycle for the 5.15.155 release.
There are 57 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.15.155-rc1

Vasiliy Kovalev <[email protected]>
VMCI: Fix possible memcpy() run-time warning in vmci_datagram_invoke_guest_handler()

Luiz Augusto von Dentz <[email protected]>
Bluetooth: btintel: Fixe build regression

Gwendal Grignou <[email protected]>
platform/x86: intel-vbtn: Update tablet mode switch at end of probe

Kees Cook <[email protected]>
randomize_kstack: Improve entropy diffusion

David Hildenbrand <[email protected]>
x86/mm/pat: fix VM_PAT handling in COW mappings

David Hildenbrand <[email protected]>
virtio: reenable config if freezing device failed

Ard Biesheuvel <[email protected]>
gcc-plugins/stackleak: Avoid .head.text section

Kees Cook <[email protected]>
gcc-plugins/stackleak: Ignore .noinstr.text and .entry.text

Thadeu Lima de Souza Cascardo <[email protected]>
tty: n_gsm: require CAP_NET_ADMIN to attach N_GSM0710 ldisc

Pablo Neira Ayuso <[email protected]>
netfilter: nf_tables: discard table flag update with pending basechain deletion

Pablo Neira Ayuso <[email protected]>
netfilter: nf_tables: release mutex after nft_gc_seq_end from abort path

Pablo Neira Ayuso <[email protected]>
netfilter: nf_tables: release batch on table validation from abort path

Roman Smirnov <[email protected]>
fbmon: prevent division by zero in fb_videomode_from_videomode()

Jiawei Fu (iBug) <[email protected]>
drivers/nvme: Add quirks for device 126f:2262

Aleksandr Burakov <[email protected]>
fbdev: viafb: fix typo in hw_bitblt_1 and hw_bitblt_2

Chancel Liu <[email protected]>
ASoC: soc-core.c: Skip dummy codec when adding platforms

Colin Ian King <[email protected]>
usb: sl811-hcd: only defined function checkdone if QUIRK2 is defined

Marco Felsch <[email protected]>
usb: typec: tcpci: add generic tcpci fallback compatible

Petre Rodan <[email protected]>
tools: iio: replace seekdir() in iio_generic_buffer

linke li <[email protected]>
ring-buffer: use READ_ONCE() to read cpu_buffer->commit_page in concurrent environment

Ricardo B. Marliere <[email protected]>
ktest: force $buildonly = 1 for 'make_warnings_file' test type

Alban Boyé <[email protected]>
platform/x86: touchscreen_dmi: Add an extra entry for a variant of the Chuwi Vi8 tablet

Gergo Koteles <[email protected]>
Input: allocate keycode for Display refresh rate toggle

Manjunath Patil <[email protected]>
RDMA/cm: add timeout to cm_destroy_id wait

Roman Smirnov <[email protected]>
block: prevent division by zero in blk_rq_stat_sum()

Ian Rogers <[email protected]>
libperf evlist: Avoid out-of-bounds access

Daniel Drake <[email protected]>
Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default"

Dai Ngo <[email protected]>
SUNRPC: increase size of rpc_wait_queue.qlen from unsigned short to unsigned int

Aric Cyr <[email protected]>
drm/amd/display: Fix nanosec stat overflow

Ye Bin <[email protected]>
ext4: forbid commit inconsistent quota data when errors=remount-ro

Zhang Yi <[email protected]>
ext4: add a hint for block bitmap corrupt state in mb_groups

Takashi Sakamoto <[email protected]>
ALSA: firewire-lib: handle quirk to calculate payload quadlets as data block counter

Arnd Bergmann <[email protected]>
media: sta2x11: fix irq handler cast

Alex Henrie <[email protected]>
isofs: handle CDs with bad root inode but good Joliet root directory

Justin Tee <[email protected]>
scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc()

Tetsuo Handa <[email protected]>
sysv: don't call sb_bread() with pointers_lock held

Geert Uytterhoeven <[email protected]>
pinctrl: renesas: checker: Limit cfg reg enum checks to provided IDs

Kunwu Chan <[email protected]>
Input: synaptics-rmi4 - fail probing if memory allocation for "phys" fails

Edward Adam Davis <[email protected]>
Bluetooth: btintel: Fix null ptr deref in btintel_read_version

Eric Dumazet <[email protected]>
net/smc: reduce rtnl pressure in smc_pnet_create_pnetids_list()

David Sterba <[email protected]>
btrfs: send: handle path ref underflow in header iterate_inode_ref()

David Sterba <[email protected]>
btrfs: export: handle invalid inode or root reference in btrfs_get_parent()

David Sterba <[email protected]>
btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks()

Baochen Qiang <[email protected]>
wifi: ath11k: decrease MHI channel buffer length to 8KB

Serge Semin <[email protected]>
net: pcs: xpcs: Return EINVAL in the internal methods

Samasth Norway Ananda <[email protected]>
tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num()

Kunwu Chan <[email protected]>
pstore/zone: Add a null pointer check to the psz_kmsg_read

Shannon Nelson <[email protected]>
ionic: set adminq irq affinity

Johan Jonker <[email protected]>
arm64: dts: rockchip: fix rk3399 hdmi ports node

Johan Jonker <[email protected]>
arm64: dts: rockchip: fix rk3328 hdmi ports node

C Cheng <[email protected]>
cpuidle: Avoid potential overflow in integer multiplication

John Ogness <[email protected]>
panic: Flush kernel log buffer at the end

Harshit Mogalapalli <[email protected]>
VMCI: Fix memcpy() run-time warning in dg_dispatch_as_host()

Markus Elfring <[email protected]>
batman-adv: Improve exception handling in batadv_throw_uevent()

Markus Elfring <[email protected]>
batman-adv: Return directly after a failed batadv_dat_select_candidates() in batadv_dat_forward_data()

Dmitry Antipov <[email protected]>
wifi: ath9k: fix LNA selection in ath_ant_try_scan()

Vladimir Oltean <[email protected]>
net: dsa: fix panic when DSA master device unbinds on shutdown


-------------

Diffstat:

Makefile | 4 +-
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 11 ++++-
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 +++++-
arch/x86/mm/pat/memtype.c | 49 +++++++++++++++-------
block/blk-stat.c | 2 +-
drivers/acpi/sleep.c | 12 ------
drivers/bluetooth/btintel.c | 2 +-
drivers/cpuidle/driver.c | 3 +-
.../gpu/drm/amd/display/modules/inc/mod_stats.h | 4 +-
drivers/infiniband/core/cm.c | 20 ++++++++-
drivers/input/rmi4/rmi_driver.c | 6 ++-
drivers/media/pci/sta2x11/sta2x11_vip.c | 9 ++--
drivers/misc/vmw_vmci/vmci_datagram.c | 6 ++-
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 ++-
drivers/net/pcs/pcs-xpcs.c | 4 +-
drivers/net/wireless/ath/ath11k/mhi.c | 2 +-
drivers/net/wireless/ath/ath9k/antenna.c | 2 +-
drivers/nvme/host/pci.c | 3 ++
drivers/pinctrl/renesas/core.c | 4 +-
drivers/platform/x86/intel/vbtn.c | 5 ++-
drivers/platform/x86/touchscreen_dmi.c | 9 ++++
drivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++-
drivers/tty/n_gsm.c | 3 ++
drivers/usb/host/sl811-hcd.c | 2 +
drivers/usb/typec/tcpm/tcpci.c | 1 +
drivers/video/fbdev/core/fbmon.c | 7 ++--
drivers/video/fbdev/via/accel.c | 4 +-
drivers/virtio/virtio.c | 10 ++++-
fs/btrfs/export.c | 9 +++-
fs/btrfs/send.c | 10 ++++-
fs/btrfs/volumes.c | 12 +++++-
fs/ext4/mballoc.c | 5 ++-
fs/ext4/super.c | 12 ++++++
fs/isofs/inode.c | 18 +++++++-
fs/pstore/zone.c | 2 +
fs/sysv/itree.c | 10 ++---
include/linux/randomize_kstack.h | 2 +-
include/linux/sunrpc/sched.h | 2 +-
include/uapi/linux/input-event-codes.h | 1 +
kernel/panic.c | 8 ++++
kernel/trace/ring_buffer.c | 2 +-
mm/memory.c | 4 ++
net/batman-adv/distributed-arp-table.c | 3 +-
net/batman-adv/main.c | 14 ++++---
net/dsa/dsa2.c | 25 +++--------
net/netfilter/nf_tables_api.c | 47 ++++++++++++++++-----
net/smc/smc_pnet.c | 10 +++++
scripts/gcc-plugins/stackleak_plugin.c | 6 +++
sound/firewire/amdtp-stream.c | 12 ++++--
sound/firewire/amdtp-stream.h | 4 ++
sound/soc/soc-core.c | 3 ++
tools/iio/iio_utils.c | 2 +-
tools/lib/perf/evlist.c | 18 +++++---
tools/lib/perf/include/internal/evlist.h | 4 +-
.../x86_energy_perf_policy.c | 1 +
tools/testing/ktest/ktest.pl | 1 +
56 files changed, 326 insertions(+), 128 deletions(-)




2024-04-11 18:13:09

by SeongJae Park

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

Hello,

On Thu, 11 Apr 2024 11:57:08 +0200 Greg Kroah-Hartman <[email protected]> wrote:

> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.

This rc kernel passes DAMON functionality test[1] on my test machine.
Attaching the test results summary below. Please note that I retrieved the
kernel from linux-stable-rc tree[2].

Tested-by: SeongJae Park <[email protected]>

[1] https://github.com/awslabs/damon-tests/tree/next/corr
[2] 857e7024b96f ("Linux 5.15.155-rc1")

Thanks,
SJ

[...]

---

ok 1 selftests: damon: debugfs_attrs.sh
ok 1 selftests: damon-tests: kunit.sh
ok 2 selftests: damon-tests: huge_count_read_write.sh
ok 3 selftests: damon-tests: buffer_overflow.sh
ok 4 selftests: damon-tests: rm_contexts.sh
ok 5 selftests: damon-tests: record_null_deref.sh
ok 6 selftests: damon-tests: dbgfs_target_ids_read_before_terminate_race.sh
ok 7 selftests: damon-tests: dbgfs_target_ids_pid_leak.sh
ok 8 selftests: damon-tests: damo_tests.sh
ok 9 selftests: damon-tests: masim-record.sh
ok 10 selftests: damon-tests: build_i386.sh
ok 11 selftests: damon-tests: build_arm64.sh
ok 12 selftests: damon-tests: build_m68k.sh
ok 13 selftests: damon-tests: build_i386_idle_flag.sh
ok 14 selftests: damon-tests: build_i386_highpte.sh
ok 15 selftests: damon-tests: build_nomemcg.sh
[33m
[92mPASS [39m

2024-04-11 19:13:48

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On 4/11/24 02:57, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian


2024-04-11 19:31:22

by Easwar Hariharan

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On 4/11/2024 2:57 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

<snip>

I wanted to repeat my request from another thread[1] here, that we revert commit 4949affd5288
("ACPI: CPPC: Use access_width over bit_width for system memory accesses") in 5.15.155 due to
known problems with the patch, so it's not lost in the mail storm.

Thanks,
Easwar

[1] https://lore.kernel.org/all/[email protected]/

2024-04-11 23:47:01

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On 4/11/24 03:57, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2024-04-12 07:29:14

by Ron Economos

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On 4/11/24 2:57 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Built and booted successfully on RISC-V RV64 (HiFive Unmatched).

Tested-by: Ron Economos <[email protected]>


2024-04-12 08:12:37

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Thu, 11 Apr 2024 11:57:08 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v5.15:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
90 tests: 90 pass, 0 fail

Linux version: 5.15.155-rc1-g857e7024b96f
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon

2024-04-12 08:28:03

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Thu, Apr 11, 2024 at 11:36:28AM -0700, Easwar Hariharan wrote:
> On 4/11/2024 2:57 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.155 release.
> > There are 57 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>
> <snip>
>
> I wanted to repeat my request from another thread[1] here, that we revert commit 4949affd5288
> ("ACPI: CPPC: Use access_width over bit_width for system memory accesses") in 5.15.155 due to
> known problems with the patch, so it's not lost in the mail storm.
>
> Thanks,
> Easwar
>
> [1] https://lore.kernel.org/all/[email protected]/

Now handled, thanks.

greg k-h

2024-04-12 18:25:14

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Thu, 11 Apr 2024 at 16:20, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <[email protected]>

NOTE:
LKFT test setup using NFSv4 do not notice LTP syscalls fcntl17 test failures.

## Build
* kernel: 5.15.155-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.15.y
* git commit: 857e7024b96feefc0c2ab59eb5e661df777e6a72
* git describe: v5.15.154-58-g857e7024b96f
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15154-58-g857e7024b96f

## Test Regressions (compared to v5.15.154)

## Metric Regressions (compared to v5.15.154)

## Test Fixes (compared to v5.15.154)

## Metric Fixes (compared to v5.15.154)

## Test result summary
total: 93809, pass: 74866, fail: 2649, skip: 16230, xfail: 64

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 104 total, 104 passed, 0 failed
* arm64: 31 total, 31 passed, 0 failed
* i386: 25 total, 25 passed, 0 failed
* mips: 22 total, 22 passed, 0 failed
* parisc: 3 total, 3 passed, 0 failed
* powerpc: 24 total, 24 passed, 0 failed
* riscv: 8 total, 8 passed, 0 failed
* s390: 9 total, 9 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 27 total, 27 passed, 0 failed

## Test suites summary
* boot
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mm
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-user_events
* kselftest-vDSO
* kselftest-watchdog
* kselftest-x86
* kselftest-zram
* kunit
* libgpiod
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org

2024-04-12 20:07:47

by Calum Mackay

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On 12/04/2024 4:57 pm, Chuck Lever III wrote:
>
>
>> On Apr 12, 2024, at 6:25 AM, Harshit Mogalapalli <[email protected]> wrote:
>>
>> Hi Greg,
>>
>>
>> On 11/04/24 15:27, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 5.15.155 release.
>>> There are 57 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
>>> Anything received after that time might be too late.
>>
>> I have noticed a regression in lts test case with nfsv4 and this was overlooked in the previous cycle(5.15.154). So the regression is from 153-->154 update. And I think that is due to nfs backports we had in 5.15.154.
>>
>> # ./runltp -d /tmpdir -s fcntl17
>>
>> <<<test_start>>>
>> tag=fcntl17 stime=1712915065
>> cmdline="fcntl17"
>> contacts=""
>> analysis=exit
>> <<<test_output>>>
>> fcntl17 0 TINFO : Enter preparation phase
>> fcntl17 0 TINFO : Exit preparation phase
>> fcntl17 0 TINFO : Enter block 1
>> fcntl17 0 TINFO : child 1 starting
>> fcntl17 0 TINFO : child 1 pid 22904 locked
>> fcntl17 0 TINFO : child 2 starting
>> fcntl17 0 TINFO : child 2 pid 22905 locked
>> fcntl17 0 TINFO : child 3 starting
>> fcntl17 0 TINFO : child 3 pid 22906 locked
>> fcntl17 0 TINFO : child 2 resuming
>> fcntl17 0 TINFO : child 3 resuming
>> fcntl17 0 TINFO : child 1 resuming
>> fcntl17 0 TINFO : child 3 lockw err 35
>> fcntl17 0 TINFO : child 3 exiting
>> fcntl17 0 TINFO : child 1 unlocked
>> fcntl17 0 TINFO : child 1 exiting
>> fcntl17 1 TFAIL : fcntl17.c:429: Alarm expired, deadlock not detected
>> fcntl17 0 TWARN : fcntl17.c:430: You may need to kill child processes by hand
>> fcntl17 2 TPASS : Block 1 PASSED
>> fcntl17 0 TINFO : Exit block 1
>> fcntl17 0 TWARN : tst_tmpdir.c:342: tst_rmdir: rmobj(/tmpdir/ltp-jRFBtBQhhx/LTP_fcnp7lqPn) failed: unlink(/tmpdir/ltp-jRFBtBQhhx/LTP_fcnp7lqPn) failed; errno=2: ENOENT
>> <<<execution_status>>>
>> initiation_status="ok"
>> duration=10 termination_type=exited termination_id=5 corefile=no
>> cutime=0 cstime=0
>> <<<test_end>>>
>> <<<test_start>>>
>> tag=fcntl17_64 stime=1712915075
>> cmdline="fcntl17_64"
>> contacts=""
>> analysis=exit
>> <<<test_output>>>
>> incrementing stop
>> fcntl17 0 TINFO : Enter preparation phase
>> fcntl17 0 TINFO : Exit preparation phase
>> fcntl17 0 TINFO : Enter block 1
>> fcntl17 0 TINFO : child 1 starting
>> fcntl17 0 TINFO : child 1 pid 22909 locked
>> fcntl17 0 TINFO : child 2 starting
>> fcntl17 0 TINFO : child 2 pid 22910 locked
>> fcntl17 0 TINFO : child 3 starting
>> fcntl17 0 TINFO : child 3 pid 22911 locked
>> fcntl17 0 TINFO : child 2 resuming
>> fcntl17 0 TINFO : child 3 resuming
>> fcntl17 0 TINFO : child 1 resuming
>> fcntl17 0 TINFO : child 3 lockw err 35
>> fcntl17 0 TINFO : child 3 exiting
>> fcntl17 0 TINFO : child 1 unlocked
>> fcntl17 0 TINFO : child 1 exiting
>> fcntl17 1 TFAIL : fcntl17.c:429: Alarm expired, deadlock not detected
>> fcntl17 0 TWARN : fcntl17.c:430: You may need to kill child processes by hand
>> fcntl17 2 TPASS : Block 1 PASSED
>> fcntl17 0 TINFO : Exit block 1
>> fcntl17 0 TWARN : tst_tmpdir.c:342: tst_rmdir: rmobj(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed: unlink(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed; errno=2: ENOENT
>> <<<execution_status>>>
>> initiation_status="ok"
>> duration=10 termination_type=exited termination_id=5 corefile=no
>> cutime=0 cstime=0
>> <<<test_end>>>
>> INFO: ltp-pan reported some tests FAIL
>> LTP Version: 20240129-167-gb592cdd0d
>>
>>
>> Steps used after installing latest ltp:
>>
>> $ mkdir /tmpdir
>> $ yum install nfs-utils -y
>> $ echo "/media *(rw,no_root_squash,sync)" >/etc/exports
>> $ systemctl start nfs-server.service
>> $ mount -o rw,nfsvers=3 127.0.0.1:/media /tmpdir
>> $ cd /opt/ltp
>> $ ./runltp -d /tmpdir -s fcntl17
>>
>>
>>
>> This does not happen in 5.15.153 tag.
>>
>> Adding nfs people to the CC list
>
> The reproducer uses NFSv3, but the bug report says NFSv4
> at the top.
>
> I was able to reproduce this on my nfsd-5.15.y branch
> with NFSv3.
>
> A bisect would be most helpful.

Interestingly, this same LTP fcntl17 test failure was reported to me
internally some time back, in late 2022; at the time it was bisected to:

6930bcbfb6ce lockd: detect and reject lock arguments that overflow
mainline v6.0-rc1
stable v5.15.61

However, the failure was intermittent, and seemed very dependent on test
system configuration; eventually it disappeared, so I put it down to
test issues.


Harshit will continue to bisect this new case.

cheers,
calum.

>
>
>> Thanks,
>> Harshit
>>
>>
>>
>>
>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.155-rc1.gz
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>>> and the diffstat can be found below.
>>> thanks,
>>> greg k-h
>
> --
> Chuck Lever
>
>



Attachments:
OpenPGP_signature.asc (855.00 B)
OpenPGP digital signature

2024-04-12 20:24:28

by Chuck Lever

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Sat, Apr 13, 2024 at 01:41:52AM +0530, Harshit Mogalapalli wrote:
> Hi Greg, Chuck,
>
> On 12/04/24 21:27, Chuck Lever III wrote:
> >
> >
> > > I have noticed a regression in lts test case with nfsv4 and this was overlooked in the previous cycle(5.15.154). So the regression is from 153-->154 update. And I think that is due to nfs backports we had in 5.15.154.
> > >
> > > # ./runltp -d /tmpdir -s fcntl17
> > >
> > > <<<test_start>>>
> > > tag=fcntl17 stime=1712915065
> ...
> > > fcntl17 1 TFAIL : fcntl17.c:429: Alarm expired, deadlock not detected
> > > fcntl17 0 TWARN : fcntl17.c:430: You may need to kill child processes by hand
> > > fcntl17 2 TPASS : Block 1 PASSED
> > > fcntl17 0 TINFO : Exit block 1
> > > fcntl17 0 TWARN : tst_tmpdir.c:342: tst_rmdir: rmobj(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed: unlink(/tmpdir/ltp-jRFBtBQhhx/LTP_fcn9Xy4hM) failed; errno=2: ENOENT
> > >
> > >
> > > Steps used after installing latest ltp:
> > >
> > > $ mkdir /tmpdir
> > > $ yum install nfs-utils -y
> > > $ echo "/media *(rw,no_root_squash,sync)" >/etc/exports
> > > $ systemctl start nfs-server.service
> > > $ mount -o rw,nfsvers=3 127.0.0.1:/media /tmpdir
> > > $ cd /opt/ltp
> > > $ ./runltp -d /tmpdir -s fcntl17
> > >
> > >
> > >
> > > This does not happen in 5.15.153 tag.
> > >
> > > Adding nfs people to the CC list
> >
> > The reproducer uses NFSv3, but the bug report says NFSv4
> > at the top.
> >
> > I was able to reproduce this on my nfsd-5.15.y branch
> > with NFSv3.
> >
> > A bisect would be most helpful.
> >
>
> I was able to bisect: here are the results:
>
>
>
> 2267b2e84593bd3d61a1188e68fba06307fa9dab is the first bad commit
> commit 2267b2e84593bd3d61a1188e68fba06307fa9dab
> Author: Alexander Aring <[email protected]>
> Date: Tue Sep 12 17:53:18 2023 -0400
>
> lockd: introduce safe async lock op
>
> [ Upstream commit 2dd10de8e6bcbacf85ad758b904543c294820c63 ]
>
> This patch reverts mostly commit 40595cdc93ed ("nfs: block notification
> on fs with its own ->lock") and introduces an EXPORT_OP_ASYNC_LOCK
> export flag to signal that the "own ->lock" implementation supports
> async lock requests. The only main user is DLM that is used by GFS2 and
> OCFS2 filesystem. Those implement their own lock() implementation and
> return FILE_LOCK_DEFERRED as return value. Since commit 40595cdc93ed
> ("nfs: block notification on fs with its own ->lock") the DLM
> implementation were never updated. This patch should prepare for DLM
> to set the EXPORT_OP_ASYNC_LOCK export flag and update the DLM
> plock implementation regarding to it.
>
> Acked-by: Jeff Layton <[email protected]>
> Signed-off-by: Alexander Aring <[email protected]>
> Signed-off-by: Chuck Lever <[email protected]>
>
> Documentation/filesystems/nfs/exporting.rst | 7 +++++++
> fs/lockd/svclock.c | 4 +---
> fs/nfsd/nfs4state.c | 10 +++++++---
> include/linux/exportfs.h | 14 ++++++++++++++
> 4 files changed, 29 insertions(+), 6 deletions(-)
>
> Bisect log:
> ==========
>
> git bisect start
> # status: waiting for both good and bad commits
> # bad: [cdfd0a7f01396303e9d4fb3513a1127636f12e5e] Linux 5.15.154
> git bisect bad cdfd0a7f01396303e9d4fb3513a1127636f12e5e
> # status: waiting for good commit(s), bad commit known
> # good: [9465fef4ae351749f7068da8c78af4ca27e61928] Linux 5.15.153
> git bisect good 9465fef4ae351749f7068da8c78af4ca27e61928
> # good: [4420d19ed4e4fe2adc9bed8a49bf195db1137458] NFSD: Report average age
> of filecache items
> git bisect good 4420d19ed4e4fe2adc9bed8a49bf195db1137458
> # good: [94e412c945e64579798204aee7bc669d0acfaf79] nfsd: fix courtesy client
> with deny mode handling in nfs4_upgrade_open
> git bisect good 94e412c945e64579798204aee7bc669d0acfaf79
> # bad: [254f1c2521716cafc63530750ce313059f5d5979] iwlwifi: mvm: rfi: use
> kmemdup() to replace kzalloc + memcpy
> git bisect bad 254f1c2521716cafc63530750ce313059f5d5979
> # bad: [e635f652696ef6f1230621cfd89c350cb5ec6169] serial: sc16is7xx: convert
> from _raw_ to _noinc_ regmap functions for FIFO
> git bisect bad e635f652696ef6f1230621cfd89c350cb5ec6169
> # good: [05b452e8748bcf92c00725691437e16d46af7c28] nfsd: Fix creation time
> serialization order
> git bisect good 05b452e8748bcf92c00725691437e16d46af7c28
> # bad: [ccd9fe71b9ee46ebcecec8aec5c4f1e1ddd35dfd] nfsd: Fix a regression in
> nfsd_setattr()
> git bisect bad ccd9fe71b9ee46ebcecec8aec5c4f1e1ddd35dfd
> # bad: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd: introduce safe
> async lock op
> git bisect bad 2267b2e84593bd3d61a1188e68fba06307fa9dab
> # good: [56e5eeff6cfa4bd6ffa2b2ae5b8bfc1c28044faf] nfsd: separate
> nfsd_last_thread() from nfsd_put()
> git bisect good 56e5eeff6cfa4bd6ffa2b2ae5b8bfc1c28044faf
> # good: [6e5fed48d8b7b25f8517a1292b62a3a86a5aec91] NFSD: fix possible oops
> when nfsd/pool_stats is closed.
> git bisect good 6e5fed48d8b7b25f8517a1292b62a3a86a5aec91
> # first bad commit: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd:
> introduce safe async lock op
>
>
> Hope the above might help.

Nice work. Thanks!


> I didnot test the revert of culprit commit on top of 5.15.154 yet.

Please try reverting that one -- it's very close to the top so one
or two others might need to be pulled off as well.

I expect this is due to a missing pre-requisite commit.


--
Chuck Lever

2024-04-12 21:35:20

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

Hi Chuck and Greg,

On 13/04/24 01:53, Chuck Lever wrote:
> On Sat, Apr 13, 2024 at 01:41:52AM +0530, Harshit Mogalapalli wrote:
>> # first bad commit: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd:
>> introduce safe async lock op
>>
>>
>> Hope the above might help.
>
> Nice work. Thanks!
>
>
>> I didnot test the revert of culprit commit on top of 5.15.154 yet.
>
> Please try reverting that one -- it's very close to the top so one
> or two others might need to be pulled off as well.
>

I have reverted the bad commit: 2267b2e84593 ("lockd: introduce safe
async lock op") and the test passes.

Note: Its reverts cleanly on 5.15.154

Thanks,
Harshit

> I expect this is due to a missing pre-requisite commit.
>
>


2024-04-12 22:22:52

by Kelsey Steele

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Thu, Apr 11, 2024 at 11:57:08AM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.155 release.
> There are 57 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 13 Apr 2024 09:53:55 +0000.
> Anything received after that time might be too late.

No regressions found on WSL (x86 and arm64).

Built, booted, and reviewed dmesg.

Thank you. :)

Tested-by: Kelsey Steele <[email protected]>

2024-04-15 13:40:09

by Chuck Lever

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/57] 5.15.155-rc1 review

On Sun, Apr 14, 2024 at 08:13:32AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Apr 13, 2024 at 11:56:15AM -0400, Chuck Lever wrote:
> > On Sat, Apr 13, 2024 at 03:04:19AM +0530, Harshit Mogalapalli wrote:
> > > Hi Chuck and Greg,
> > >
> > > On 13/04/24 01:53, Chuck Lever wrote:
> > > > On Sat, Apr 13, 2024 at 01:41:52AM +0530, Harshit Mogalapalli wrote:
> > > > > # first bad commit: [2267b2e84593bd3d61a1188e68fba06307fa9dab] lockd:
> > > > > introduce safe async lock op
> > > > >
> > > > >
> > > > > Hope the above might help.
> > > >
> > > > Nice work. Thanks!
> > > >
> > > >
> > > > > I didnot test the revert of culprit commit on top of 5.15.154 yet.
> > > >
> > > > Please try reverting that one -- it's very close to the top so one
> > > > or two others might need to be pulled off as well.
> > > >
> > >
> > > I have reverted the bad commit: 2267b2e84593 ("lockd: introduce safe async
> > > lock op") and the test passes.
> > >
> > > Note: Its reverts cleanly on 5.15.154
> >
> > Harshit also informs me that "lockd: introduce safe async lock op"
> > is not applied to v6.1, so it's not likely necessary to include here
> > and can be safely reverted from v5.15.y.
>
> Chuck, can you send a series of reverts for what needs to be done here
> as these were your original backports?

Testing now, I'll send the patch in a day or two.


--
Chuck Lever