2024-04-15 02:36:17

by Jiapeng Chong

Subject: [PATCH] bcachefs: remove unneeded semicolon

No functional modification involved.

/fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
/fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/bcachefs/super.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
index 8daf80a38d60..234f19ea8f30 100644
--- a/fs/bcachefs/super.c
+++ b/fs/bcachefs/super.c
@@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,

prt_bdevname(&buf, fs->bdev);
prt_char(&buf, ' ');
- bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
+ bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
prt_newline(&buf);

prt_bdevname(&buf, sb->bdev);
prt_char(&buf, ' ');
- bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
+ bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
prt_newline(&buf);

if (!opts->no_splitbrain_check)
--
2.20.1.7.g153144c

2024-04-15 02:48:56

by Hongbo Li

Subject: Re: [PATCH] bcachefs: remove unneeded semicolon

Maybe it is not enough, you can use "grep -rn ');;' fs/bcachefs/" to
find out all the same format.

On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> fs/bcachefs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>
> prt_bdevname(&buf, fs->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
> prt_newline(&buf);
>
> prt_bdevname(&buf, sb->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
> prt_newline(&buf);
>
> if (!opts->no_splitbrain_check)

2024-04-15 02:55:37

by Hongbo Li

Subject: Re: [PATCH] bcachefs: remove unneeded semicolon

I remember other people also submit this likely patch:

https://lore.kernel.org/linux-bcachefs/[email protected]/

https://lore.kernel.org/linux-bcachefs/[email protected]/

On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> fs/bcachefs/super.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>
> prt_bdevname(&buf, fs->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
> prt_newline(&buf);
>
> prt_bdevname(&buf, sb->bdev);
> prt_char(&buf, ' ');
> - bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> + bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
> prt_newline(&buf);
>
> if (!opts->no_splitbrain_check)