2024-04-16 07:35:35

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the mm-hotfixes tree

Hi all,

After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
produced this warning:

lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead

Introduced by commit

aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")

from the mm-hotfixes-unstable branch of the mm-hotfixes tree.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-04-16 18:54:04

by Andrew Morton

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the mm-hotfixes tree

On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell <[email protected]> wrote:

> Hi all,
>
> After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> produced this warning:
>
> lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
> lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
>
> Introduced by commit
>
> aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
>
> from the mm-hotfixes-unstable branch of the mm-hotfixes tree.

Thanks. How's this?

--- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix
+++ a/lib/bootconfig.c
@@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void)
}

/**
- * xbc_exit() - Clean up all parsed bootconfig
+ * _xbc_exit() - Clean up all parsed bootconfig
+ * @early: in early xbc init error
*
* This clears all data structures of parsed bootconfig on memory.
* If you need to reuse xbc_init() with new boot config, you can
_


2024-04-17 05:37:12

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the mm-hotfixes tree

Hi Andrew,

On Tue, 16 Apr 2024 11:51:14 -0700 Andrew Morton <[email protected]> wrote:
>
> On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell <[email protected]> wrote:
>
> > After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
> > lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
> >
> > Introduced by commit
> >
> > aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
> >
> > from the mm-hotfixes-unstable branch of the mm-hotfixes tree.
>
> Thanks. How's this?
>
> --- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix
> +++ a/lib/bootconfig.c
> @@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void)
> }
>
> /**
> - * xbc_exit() - Clean up all parsed bootconfig
> + * _xbc_exit() - Clean up all parsed bootconfig
> + * @early: in early xbc init error
> *
> * This clears all data structures of parsed bootconfig on memory.
> * If you need to reuse xbc_init() with new boot config, you can
> _
>

OK, so the above two warnings went away, but now I get

lib/bootconfig.c:909: warning: expecting prototype for _xbc_exit(). Prototype was for xbc_exit() instead

Commit

aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")

that was in the mm tree yesterday is not there now.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-04-17 21:01:02

by Andrew Morton

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the mm-hotfixes tree

On Wed, 17 Apr 2024 15:29:04 +1000 Stephen Rothwell <[email protected]> wrote:

> > * This clears all data structures of parsed bootconfig on memory.
> > * If you need to reuse xbc_init() with new boot config, you can
> > _
> >
>
> OK, so the above two warnings went away, but now I get
>
> lib/bootconfig.c:909: warning: expecting prototype for _xbc_exit(). Prototype was for xbc_exit() instead
>
> Commit
>
> aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
>
> that was in the mm tree yesterday is not there now.

oop, sorry, fat-fingered that one. Thanks, I brought back
bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy.patch.