2024-04-18 00:51:21

by Youling Tang

Subject: [PATCH v2] bcachefs: Align the display format of `btrees/inodes/keys`

From: Youling Tang <[email protected]>

Before patch:
```
#cat btrees/inodes/keys
u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0: mode=40755
flags= (16300000)
bi_size=0
```

After patch:
```
#cat btrees/inodes/keys
u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:
mode=40755
flags=(16300000)
bi_size=0
```

Signed-off-by: Youling Tang <[email protected]>
---
v2:
- Adjust where to add new lines of code.
- Remove flags ` ` by Hongbo suggestion.

fs/bcachefs/inode.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/bcachefs/inode.c b/fs/bcachefs/inode.c
index f0da2b0048cc..5c9ee41baa72 100644
--- a/fs/bcachefs/inode.c
+++ b/fs/bcachefs/inode.c
@@ -534,12 +534,13 @@ int bch2_inode_v3_invalid(struct bch_fs *c, struct bkey_s_c k,
static void __bch2_inode_unpacked_to_text(struct printbuf *out,
struct bch_inode_unpacked *inode)
{
+ prt_printf(out, "\n");
printbuf_indent_add(out, 2);
prt_printf(out, "mode=%o\n", inode->bi_mode);

prt_str(out, "flags=");
prt_bitflags(out, bch2_inode_flag_strs, inode->bi_flags & ((1U << 20) - 1));
- prt_printf(out, " (%x)\n", inode->bi_flags);
+ prt_printf(out, "(%x)\n", inode->bi_flags);

prt_printf(out, "journal_seq=%llu\n", inode->bi_journal_seq);
prt_printf(out, "bi_size=%llu\n", inode->bi_size);
--
2.34.1

2024-04-18 01:10:09

by Hongbo Li

Subject: Re: [PATCH v2] bcachefs: Align the display format of `btrees/inodes/keys`

On 2024/4/18 8:50, Youling Tang wrote:
> From: Youling Tang <[email protected]>
>
> Before patch:
> ```
> #cat btrees/inodes/keys
> u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0: mode=40755
> flags= (16300000)
> bi_size=0
> ```
>
> After patch:
> ```
> #cat btrees/inodes/keys
> u64s 17 type inode_v3 0:4096:U32_MAX len 0 ver 0:
> mode=40755
> flags=(16300000)
> bi_size=0
> ```
>
> Signed-off-by: Youling Tang <[email protected]>
> ---
> v2:
> - Adjust where to add new lines of code.
> - Remove flags ` ` by Hongbo suggestion.
>
> fs/bcachefs/inode.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/bcachefs/inode.c b/fs/bcachefs/inode.c
> index f0da2b0048cc..5c9ee41baa72 100644
> --- a/fs/bcachefs/inode.c
> +++ b/fs/bcachefs/inode.c
> @@ -534,12 +534,13 @@ int bch2_inode_v3_invalid(struct bch_fs *c, struct bkey_s_c k,
> static void __bch2_inode_unpacked_to_text(struct printbuf *out,
> struct bch_inode_unpacked *inode)
> {
> + prt_printf(out, "\n");
> printbuf_indent_add(out, 2);
> prt_printf(out, "mode=%o\n", inode->bi_mode);
>
> prt_str(out, "flags=");
> prt_bitflags(out, bch2_inode_flag_strs, inode->bi_flags & ((1U << 20) - 1));
> - prt_printf(out, " (%x)\n", inode->bi_flags);
> + prt_printf(out, "(%x)\n", inode->bi_flags);
>
> prt_printf(out, "journal_seq=%llu\n", inode->bi_journal_seq);
> prt_printf(out, "bi_size=%llu\n", inode->bi_size);

Reviewed-by: Hongbo Li <[email protected]>

Thanks.
Hongbo Li