2024-04-24 05:14:21

by Ji Sheng Teoh

Subject: [PATCH v1 0/2] Add optional reset control for Cadence SPI

The first patch adds optional reset control to support assertion and
deassertion of reset signal to properly bring the SPI device into an
operating condition.
The second patch documents the optional reset control into dt-bindings.

Ji Sheng Teoh (2):
spi: spi-cadence: Add optional reset control support
dt-bindings: spi: spi-cadence: Add optional reset control

.../devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
drivers/spi/spi-cadence.c | 12 ++++++++++++
2 files changed, 17 insertions(+)

--
2.43.2

2024-04-24 05:15:44

by Ji Sheng Teoh

Subject: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

Document the optional reset control to SPI.

Signed-off-by: Eng Lee Teh <[email protected]>
Signed-off-by: Ley Foon Tan <[email protected]>
Signed-off-by: Ji Sheng Teoh <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
index d4b61b0e8301..2358489be4bc 100644
--- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
@@ -55,6 +55,11 @@ properties:
label:
description: Descriptive name of the SPI controller.

+ resets:
+ description: |
+ Optional entry to specify the reset controller to the SPI
+ maxItems: 1
+
required:
- compatible
- reg
--
2.43.2

2024-04-24 20:16:53

by Rob Herring (Arm)

Subject: Re: [PATCH v1 2/2] dt-bindings: spi: spi-cadence: Add optional reset control

On Wed, Apr 24, 2024 at 01:13:17PM +0800, Ji Sheng Teoh wrote:
> Document the optional reset control to SPI.
>
> Signed-off-by: Eng Lee Teh <[email protected]>
> Signed-off-by: Ley Foon Tan <[email protected]>
> Signed-off-by: Ji Sheng Teoh <[email protected]>

3 people developed 4 lines of code? Generally the first S-o-b should be
the author (.i.e. a From line).

> ---
> Documentation/devicetree/bindings/spi/spi-cadence.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> index d4b61b0e8301..2358489be4bc 100644
> --- a/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> @@ -55,6 +55,11 @@ properties:
> label:
> description: Descriptive name of the SPI controller.
>
> + resets:
> + description: |
> + Optional entry to specify the reset controller to the SPI

Drop the description.

> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.43.2
>