2024-04-30 03:48:13

by Jiapeng Chong

Subject: [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header

/fs/xfs/libxfs/xfs_trans_resv.c: xfs_da_format.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8931
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/xfs/libxfs/xfs_trans_resv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_trans_resv.c b/fs/xfs/libxfs/xfs_trans_resv.c
index 6dbe6e7251e7..3dc8f785bf29 100644
--- a/fs/xfs/libxfs/xfs_trans_resv.c
+++ b/fs/xfs/libxfs/xfs_trans_resv.c
@@ -22,7 +22,6 @@
#include "xfs_rtbitmap.h"
#include "xfs_attr_item.h"
#include "xfs_log.h"
-#include "xfs_da_format.h"

#define _ALLOC true
#define _FREE false
--
2.20.1.7.g153144c

2024-04-30 04:04:22

by Christoph Hellwig

Subject: Re: [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header

On Tue, Apr 30, 2024 at 11:47:27AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_trans_resv.c: xfs_da_format.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8931

I don't think we do Closes for random bugzilla, never mind for trivial
cleanups.

The changes itself looks fine, though:

Reviewed-by: Christoph Hellwig <[email protected]>