2024-05-01 09:54:30

by Usama Arif

[permalink] [raw]
Subject: [PATCH] cgroup: Add documentation for missing zswap memory.stat

This includes zswpin, zswpout and zswpwb.

Signed-off-by: Usama Arif <[email protected]>
---
Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 17e6e9565156..48ec54627814 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1454,6 +1454,15 @@ PAGE_SIZE multiple when read back.
zswapped
Amount of application memory swapped out to zswap.

+ zswpin
+ Number of pages moved in to memory from zswap.
+
+ zswpout
+ Number of pages moved out of memory to zswap.
+
+ zswpwb
+ Number of pages written from zswap to swap.
+
file_mapped
Amount of cached filesystem data mapped with mmap()

--
2.43.0



2024-05-01 12:02:20

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH] cgroup: Add documentation for missing zswap memory.stat

On Wed, May 01, 2024 at 10:53:49AM +0100, Usama Arif wrote:
> This includes zswpin, zswpout and zswpwb.

Good idea adding these!

> Signed-off-by: Usama Arif <[email protected]>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..48ec54627814 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1454,6 +1454,15 @@ PAGE_SIZE multiple when read back.
> zswapped
> Amount of application memory swapped out to zswap.
>
> + zswpin
> + Number of pages moved in to memory from zswap.
> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +

They should go between pglazyfreed and thp_fault_alloc to match the
output ordering (they're event counters, not memory counters).

> file_mapped
> Amount of cached filesystem data mapped with mmap()
>