2024-04-30 21:37:06

by Laurent Pinchart

Subject: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

The unicam driver uses the v4l2_subdev structure. Include the
corresponding header instead of relying on indirect includes.

Signed-off-by: Laurent Pinchart <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
index c590e26fe2cf..3c7878d8d79b 100644
--- a/drivers/media/platform/broadcom/bcm2835-unicam.c
+++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
@@ -55,6 +55,7 @@
#include <media/v4l2-ioctl.h>
#include <media/v4l2-fwnode.h>
#include <media/v4l2-mc.h>
+#include <media/v4l2-subdev.h>
#include <media/videobuf2-dma-contig.h>

#include "bcm2835-unicam-regs.h"
--
Regards,

Laurent Pinchart

2024-05-01 11:08:08

by Ricardo Ribalda Delgado

Subject: Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

Hi Laurent

I have to send a v2 of
https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
can include this patch in that set if you want

Regards!

On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart
<[email protected]> wrote:
>
> The unicam driver uses the v4l2_subdev structure. Include the
> corresponding header instead of relying on indirect includes.
>
> Signed-off-by: Laurent Pinchart <[email protected]>
> Reported-by: kernel test robot <[email protected]>
Reviewed-by: Ricardo Ribalda <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> ---
> drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> index c590e26fe2cf..3c7878d8d79b 100644
> --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> @@ -55,6 +55,7 @@
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-fwnode.h>
> #include <media/v4l2-mc.h>
> +#include <media/v4l2-subdev.h>
> #include <media/videobuf2-dma-contig.h>
>
> #include "bcm2835-unicam-regs.h"
> --
> Regards,
>
> Laurent Pinchart
>
>


--
Ricardo Ribalda

2024-05-01 11:47:43

by Laurent Pinchart

Subject: Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

Hi Ricardo,

On Wed, May 01, 2024 at 01:07:29PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Laurent
>
> I have to send a v2 of
> https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
> can include this patch in that set if you want

Fine with me.

> On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart wrote:
> >
> > The unicam driver uses the v4l2_subdev structure. Include the
> > corresponding header instead of relying on indirect includes.
> >
> > Signed-off-by: Laurent Pinchart <[email protected]>
> > Reported-by: kernel test robot <[email protected]>
> Reviewed-by: Ricardo Ribalda <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > ---
> > drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > index c590e26fe2cf..3c7878d8d79b 100644
> > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > @@ -55,6 +55,7 @@
> > #include <media/v4l2-ioctl.h>
> > #include <media/v4l2-fwnode.h>
> > #include <media/v4l2-mc.h>
> > +#include <media/v4l2-subdev.h>
> > #include <media/videobuf2-dma-contig.h>
> >
> > #include "bcm2835-unicam-regs.h"

--
Regards,

Laurent Pinchart

2024-05-01 11:56:25

by Laurent Pinchart

Subject: Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h

On Wed, May 01, 2024 at 02:47:15PM +0300, Laurent Pinchart wrote:
> On Wed, May 01, 2024 at 01:07:29PM +0200, Ricardo Ribalda Delgado wrote:
> > Hi Laurent
> >
> > I have to send a v2 of
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
> > can include this patch in that set if you want
>
> Fine with me.

Assuming your v2 will be merged in v6.10.

> > On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart wrote:
> > >
> > > The unicam driver uses the v4l2_subdev structure. Include the
> > > corresponding header instead of relying on indirect includes.
> > >
> > > Signed-off-by: Laurent Pinchart <[email protected]>
> > > Reported-by: kernel test robot <[email protected]>
> > Reviewed-by: Ricardo Ribalda <[email protected]>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > > ---
> > > drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > index c590e26fe2cf..3c7878d8d79b 100644
> > > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > @@ -55,6 +55,7 @@
> > > #include <media/v4l2-ioctl.h>
> > > #include <media/v4l2-fwnode.h>
> > > #include <media/v4l2-mc.h>
> > > +#include <media/v4l2-subdev.h>
> > > #include <media/videobuf2-dma-contig.h>
> > >
> > > #include "bcm2835-unicam-regs.h"

--
Regards,

Laurent Pinchart