2024-05-02 18:53:22

by Usama Arif

[permalink] [raw]
Subject: [PATCH v2 0/1] cgroup: Add documentation for missing zswap memory.stat

This includes zswpin, zswpout and zswpwb.

v1 -> v2:
- Move doc location according to output ordering in
memory.stat (Johannes Weiner)

Usama Arif (1):
cgroup: Add documentation for missing zswap memory.stat

Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
1 file changed, 9 insertions(+)

--
2.43.0



2024-05-02 18:53:34

by Usama Arif

[permalink] [raw]
Subject: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat

This includes zswpin, zswpout and zswpwb.

Signed-off-by: Usama Arif <[email protected]>
---
Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 17e6e9565156..eaf9e66e472a 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
pglazyfreed (npn)
Amount of reclaimed lazyfree pages

+ zswpin
+ Number of pages moved in to memory from zswap.
+
+ zswpout
+ Number of pages moved out of memory to zswap.
+
+ zswpwb
+ Number of pages written from zswap to swap.
+
thp_fault_alloc (npn)
Number of transparent hugepages which were allocated to satisfy
a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE
--
2.43.0


2024-05-02 23:29:14

by Nhat Pham

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat

On Thu, May 2, 2024 at 11:53 AM Usama Arif <[email protected]> wrote:
>
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <[email protected]>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
> pglazyfreed (npn)
> Amount of reclaimed lazyfree pages
>
> + zswpin
> + Number of pages moved in to memory from zswap.

nit: into?

> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +
> thp_fault_alloc (npn)
> Number of transparent hugepages which were allocated to satisfy
> a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE
> --
> 2.43.0
>

That very small nit aside, LGTM. Thanks for completing the documentation.
Acked-by: Nhat Pham <[email protected]>

2024-05-03 08:20:32

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat

On Thu, May 02, 2024 at 07:50:24PM +0100, Usama Arif wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
> pglazyfreed (npn)
> Amount of reclaimed lazyfree pages
>
> + zswpin
> + Number of pages moved in to memory from zswap.
> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +
> thp_fault_alloc (npn)
> Number of transparent hugepages which were allocated to satisfy
> a page fault. This counter is not present when CONFIG_TRANSPARENT_HUGEPAGE

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <[email protected]>

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (957.00 B)
signature.asc (235.00 B)
Download all attachments

2024-05-03 14:55:01

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat

On Thu, May 02, 2024 at 07:50:24PM +0100, Usama Arif wrote:
> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <[email protected]>

Acked-by: Johannes Weiner <[email protected]>

2024-05-09 16:54:03

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] cgroup: Add documentation for missing zswap memory.stat

Usama Arif <[email protected]> writes:

> This includes zswpin, zswpout and zswpwb.
>
> Signed-off-by: Usama Arif <[email protected]>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..eaf9e66e472a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1572,6 +1572,15 @@ PAGE_SIZE multiple when read back.
> pglazyfreed (npn)
> Amount of reclaimed lazyfree pages
>
> + zswpin
> + Number of pages moved in to memory from zswap.
> +
> + zswpout
> + Number of pages moved out of memory to zswap.
> +
> + zswpwb
> + Number of pages written from zswap to swap.
> +

Applied, thanks.

jon