2024-05-02 20:05:46

by Usama Arif

Subject: [PATCH v2 0/1] cgroup: remove redundant addition of memory controller

Memory controller is already added in main which invokes
the test, hence this does not need to be done in
test_no_kmem_bypass.

v1 -> v2:
- Add more description to commit message.

Usama Arif (1):
selftests: cgroup: remove redundant addition of memory controller

tools/testing/selftests/cgroup/test_zswap.c | 2 --
1 file changed, 2 deletions(-)

--
2.43.0

2024-05-02 20:05:53

by Usama Arif

Subject: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of memory controller

Memory controller is already added in main which invokes
the test, hence this does not need to be done in test_no_kmem_bypass.

Signed-off-by: Usama Arif <[email protected]>
---
tools/testing/selftests/cgroup/test_zswap.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
index cd864ab825d0..19ac29c533e0 100644
--- a/tools/testing/selftests/cgroup/test_zswap.c
+++ b/tools/testing/selftests/cgroup/test_zswap.c
@@ -485,8 +485,6 @@ static int test_no_kmem_bypass(const char *root)
trigger_allocation_size = sys_info.totalram / 20;

/* Set up test memcg */
- if (cg_write(root, "cgroup.subtree_control", "+memory"))
- goto out;
test_group = cg_name(root, "kmem_bypass_test");
if (!test_group)
goto out;
--
2.43.0

2024-05-03 02:07:37

by Yosry Ahmed

Subject: Re: [PATCH v2 1/1] selftests: cgroup: remove redundant addition of memory controller

On Thu, May 2, 2024 at 1:05 PM Usama Arif <[email protected]> wrote:
>
> Memory controller is already added in main which invokes
> the test, hence this does not need to be done in test_no_kmem_bypass.

nit: The memory controller is "enabled", not added. Same for the subject line.

>
> Signed-off-by: Usama Arif <[email protected]>

Acked-by: Yosry Ahmed <[email protected]>

> ---
> tools/testing/selftests/cgroup/test_zswap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index cd864ab825d0..19ac29c533e0 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -485,8 +485,6 @@ static int test_no_kmem_bypass(const char *root)
> trigger_allocation_size = sys_info.totalram / 20;
>
> /* Set up test memcg */
> - if (cg_write(root, "cgroup.subtree_control", "+memory"))
> - goto out;
> test_group = cg_name(root, "kmem_bypass_test");
> if (!test_group)
> goto out;
> --
> 2.43.0
>

2024-05-03 02:10:23

by Yosry Ahmed

Subject: Re: [PATCH v2 0/1] cgroup: remove redundant addition of memory controller

On Thu, May 2, 2024 at 1:05 PM Usama Arif <[email protected]> wrote:
>
> Memory controller is already added in main which invokes
> the test, hence this does not need to be done in
> test_no_kmem_bypass.

A cover letter is not required. In cases like this where providing
additional context to the commit log is not needed, it is better to
omit it. This especially applies when there is a single patch in the
series.

If you want to add version diff info or any additional context, you
can add it after "---" in the patch itself. Example:
https://lore.kernel.org/linux-mm/[email protected]/.

>
> v1 -> v2:
> - Add more description to commit message.
>
> Usama Arif (1):
> selftests: cgroup: remove redundant addition of memory controller
>
> tools/testing/selftests/cgroup/test_zswap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --
> 2.43.0
>