2024-05-02 22:53:54

by Jeff Xu

Subject: [PATCH v1 0/1] selftest/mseal fix arm build

From: Jeff Xu <[email protected]>

This is followup on arm build failure reported by
Ryan Roberts [1]

I don't have right setup to repro the issue, so would need some
help to verify this in arm build.

[1] https://lore.kernel.org/lkml/[email protected]/


Jeff Xu (1):
selftest mm/mseal: fix arm build

tools/testing/selftests/mm/mseal_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--
2.45.0.rc1.225.g2a3ae87e7f-goog

2024-05-02 22:53:57

by Jeff Xu

Subject: [PATCH v1 1/1] selftest mm/mseal: fix arm build

From: Jeff Xu <[email protected]>

add include linux/mman.h to fix arm build
fix a typo

Signed-off-by: Jeff Xu <[email protected]>
Suggested-by: Ryan Roberts <[email protected]>
---
tools/testing/selftests/mm/mseal_test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index ca8dbee0c612..41998cf1dcf5 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0
#define _GNU_SOURCE
+#include <linux/mman.h>
#include <sys/mman.h>
#include <stdint.h>
#include <unistd.h>
@@ -29,7 +30,7 @@
# define PKEY_DISABLE_WRITE 0x2
#endif

-#ifndef PKEY_BITS_PER_KEY
+#ifndef PKEY_BITS_PER_PKEY
#define PKEY_BITS_PER_PKEY 2
#endif

--
2.45.0.rc1.225.g2a3ae87e7f-goog

2024-05-03 11:02:37

by Ryan Roberts

Subject: Re: [PATCH v1 1/1] selftest mm/mseal: fix arm build

On 02/05/2024 23:53, [email protected] wrote:
> From: Jeff Xu <[email protected]>
>
> add include linux/mman.h to fix arm build
> fix a typo
>
> Signed-off-by: Jeff Xu <[email protected]>
> Suggested-by: Ryan Roberts <[email protected]>

I confirm this has fixed our issue. Thanks!

Tested-by: Ryan Roberts <[email protected]>
Reviewed-by: Ryan Roberts <[email protected]>

> ---
> tools/testing/selftests/mm/mseal_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
> index ca8dbee0c612..41998cf1dcf5 100644
> --- a/tools/testing/selftests/mm/mseal_test.c
> +++ b/tools/testing/selftests/mm/mseal_test.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> #define _GNU_SOURCE
> +#include <linux/mman.h>
> #include <sys/mman.h>
> #include <stdint.h>
> #include <unistd.h>
> @@ -29,7 +30,7 @@
> # define PKEY_DISABLE_WRITE 0x2
> #endif
>
> -#ifndef PKEY_BITS_PER_KEY
> +#ifndef PKEY_BITS_PER_PKEY
> #define PKEY_BITS_PER_PKEY 2
> #endif
>